Bug 65596

Summary:

[EFL] Implement dummy IconDatabaseClientEfl

Product:

WebKit

Reporter:

Jaehun Lim <ljaehun.lim>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none

Jaehun Lim

Reported 2011-08-03 00:21:26 PDT

Adds two files, IconDatabaseClientEfl.h | .cpp to implement IconDatabaseClient for EFL port.

Attachments
Proposed patch (5.14 KB, patch) 2011-08-03 00:24 PDT, Jaehun Lim	no flags	Details Formatted Diff Diff
Proposed patch (5.13 KB, patch) 2011-08-03 15:24 PDT, Jaehun Lim	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jaehun Lim

Comment 1 2011-08-03 00:24:45 PDT

Created attachment 102746 [details] Proposed patch

Leandro Pereira

Comment 2 2011-08-03 08:21:08 PDT

Comment on attachment 102746 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=102746&action=review LGTM, just a minor nit. > Source/WebKit/efl/WebCoreSupport/IconDatabaseClientEfl.cpp:39 > +void IconDatabaseClientEfl::didImportIconURLForPageURL(const String& url) Unused parameters shouldn't have their names declared.

Jaehun Lim

Comment 3 2011-08-03 15:24:26 PDT

Created attachment 102838 [details] Proposed patch Thanks for your comments. I uploaded a new patch.

Gyuyoung Kim

Comment 4 2011-08-08 17:34:12 PDT

LGTM.

Gyuyoung Kim

Comment 5 2011-08-23 20:53:35 PDT

Kent, could you please review this patch as well ?

WebKit Review Bot

Comment 6 2011-08-24 02:49:01 PDT

Comment on attachment 102838 [details] Proposed patch Clearing flags on attachment: 102838 Committed r93697: <http://trac.webkit.org/changeset/93697>

WebKit Review Bot

Comment 7 2011-08-24 02:49:06 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.