Summary: | Web Inspector: remove Node parameter from the InspectorClient::highlight | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Pavel Feldman
2011-08-02 10:27:04 PDT
Created attachment 102666 [details]
Patch
Comment on attachment 102666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102666&action=review > Source/WebCore/inspector/InspectorClient.h:47 > + virtual void highlight() = 0; Now that there is no Node parameter, I think we should rename the method to something that would better reflect it purpose and start with a verb, probably drawHighlight? (In reply to comment #2) > (From update of attachment 102666 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102666&action=review > > > Source/WebCore/inspector/InspectorClient.h:47 > > + virtual void highlight() = 0; > > Now that there is no Node parameter, I think we should rename the method to something that would better reflect it purpose and start with a verb, probably drawHighlight? My fingers are falling apart after this rename. You do that :P Comment on attachment 102666 [details] Patch Clearing flags on attachment: 102666 Committed r92265: <http://trac.webkit.org/changeset/92265> All reviewed patches have been landed. Closing bug. |