Bug 6553

Summary:

Remove KCanvasCommonArgs and pass around RenderPath objects instead.

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

6447

Bug Blocks:

6448, 6564

Attachments:

Description	Flags
remove kcanvascommonargs	none
remove kcanvascommonargs (pass around only renderpath)	andersca: review-
new patch based on suggestions from andersca	andersca: review+

Eric Seidel (no email)

Reported 2006-01-14 21:50:13 PST

KCanvas needs to be redesigned to fill & stroke at once This is a continuation of 6447. In the previous bug, Alexander made more progress removing crufty pieces of KCanvas (namely KCanvasRenderingStyle). However a couple things remain: 1. Update PaintServers to not paint directly, but rather have an apply(STROKE | FILL) method which applies their stoke/fill properties to the current context. 2. Change RenderPathQuartz to call CGContextDrawPath, and thus both stroke and fill a path in a single call (large perf. gain).

Attachments
remove kcanvascommonargs (13.21 KB, patch) 2006-01-15 05:02 PST, Alexander Kellett	no flags	Details Formatted Diff Diff
remove kcanvascommonargs (pass around only renderpath) (22.21 KB, patch) 2006-01-15 05:32 PST, Alexander Kellett	andersca: review-	Details Formatted Diff Diff
new patch based on suggestions from andersca (22.28 KB, patch) 2006-01-15 06:51 PST, Alexander Kellett	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexander Kellett

Comment 1 2006-01-15 05:02:29 PST

Created attachment 5693 [details] remove kcanvascommonargs

Alexander Kellett

Comment 2 2006-01-15 05:32:22 PST

Created attachment 5694 [details] remove kcanvascommonargs (pass around only renderpath) new patch based on input from mjs

Anders Carlsson

Comment 3 2006-01-15 06:31:38 PST

Comment on attachment 5694 [details] remove kcanvascommonargs (pass around only renderpath) Patch looks great, a few minor comments though: - for pointer types (such as RenderPath), the * should be next to the identifier, not the type. - The RenderPath parameter should really be const. This might require having to modify other function declarations called by the different draw implementations

Alexander Kellett

Comment 4 2006-01-15 06:51:48 PST

Created attachment 5697 [details] new patch based on suggestions from andersca

Anders Carlsson

Comment 5 2006-01-15 06:58:39 PST

Comment on attachment 5697 [details] new patch based on suggestions from andersca r=me

Note You need to log in before you can comment on or make changes to this bug.