Bug 65522

Summary: Optimizing arithmetic composite filter to ARM-neon SIMD instruction set
Product: WebKit Reporter: Felician Marton <felician>
Component: SVGAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: dglazkov, loki, webkit.review.bot, zherczeg, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Description Flags
Arithmetic composite neon brief patch
webkit.review.bot: commit-queue-
patch again krit: review+, krit: commit-queue-

Description Felician Marton 2011-08-02 01:32:22 PDT
Fasten up the arithmetic composite filter.
Comment 1 Gabor Loki 2011-10-05 01:54:49 PDT
Is there any progress on this topic? or should we close this bug?
Comment 2 Felician Marton 2011-10-05 04:59:33 PDT
Created attachment 109774 [details]
Arithmetic composite neon brief patch

The MAC project file update is missing from the patch.
Comment 3 Zoltan Herczeg 2011-10-24 02:34:23 PDT
Created attachment 112164 [details]
Comment 4 WebKit Review Bot 2011-10-24 02:38:29 PDT
Comment on attachment 112164 [details]

Attachment 112164 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10201753
Comment 5 Gyuyoung Kim 2011-10-24 02:38:37 PDT
Comment on attachment 112164 [details]

Attachment 112164 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10203712
Comment 6 Early Warning System Bot 2011-10-24 02:42:53 PDT
Comment on attachment 112164 [details]

Attachment 112164 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10200772
Comment 7 Zoltan Herczeg 2011-10-24 02:43:07 PDT
Created attachment 112165 [details]
patch again
Comment 8 Dirk Schulze 2011-11-02 06:41:08 PDT
Comment on attachment 112165 [details]
patch again

View in context: https://bugs.webkit.org/attachment.cgi?id=112165&action=review

LGTM. I can just trust you on the Neon code. Just some snippets.

> Source/WebCore/ChangeLog:12
> +        for all four RGBA channels in the same time.

at the same time?

> Source/WebCore/ChangeLog:13
> +

Just mention that it won't affect the general behavior and existing tests will cover the changes.

> Source/WebCore/platform/graphics/filters/FEComposite.cpp:123
> -    float scaledK4;
> -    float scaledK1;
> +    float scaledK1, scaledK4;

that is not allowed according the webkit style rules. Just leave it as it was.

> Source/WebCore/platform/graphics/filters/FEComposite.cpp:180
> +    ASSERT(!(pixelArrayLength & 0x3));

where is pixelArrayLength?
Comment 9 Zoltan Herczeg 2011-11-04 05:06:31 PDT
Landed in trac.webkit.org/changeset/99183
Closing bug.