Bug 65522

Summary:

Optimizing arithmetic composite filter to ARM-neon SIMD instruction set

Product:

WebKit

Reporter:

Felician Marton <felician>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, loki, webkit.review.bot, zherczeg, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Unspecified

Attachments:

Description	Flags
Arithmetic composite neon brief patch	none
patch	webkit.review.bot: commit-queue-
patch again	krit: review+, krit: commit-queue-

Felician Marton

Reported 2011-08-02 01:32:22 PDT

Fasten up the arithmetic composite filter.

Attachments
Arithmetic composite neon brief patch (19.67 KB, patch) 2011-10-05 04:59 PDT, Felician Marton	no flags	Details Formatted Diff Diff
patch (18.16 KB, patch) 2011-10-24 02:34 PDT, Zoltan Herczeg	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patch again (18.15 KB, patch) 2011-10-24 02:43 PDT, Zoltan Herczeg	krit: review+ krit: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gabor Loki

Comment 1 2011-10-05 01:54:49 PDT

Is there any progress on this topic? or should we close this bug?

Felician Marton

Comment 2 2011-10-05 04:59:33 PDT

Created attachment 109774 [details] Arithmetic composite neon brief patch The MAC project file update is missing from the patch.

Zoltan Herczeg

Comment 3 2011-10-24 02:34:23 PDT

Created attachment 112164 [details] patch

WebKit Review Bot

Comment 4 2011-10-24 02:38:29 PDT

Comment on attachment 112164 [details] patch Attachment 112164 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10201753

Gyuyoung Kim

Comment 5 2011-10-24 02:38:37 PDT

Comment on attachment 112164 [details] patch Attachment 112164 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10203712

Early Warning System Bot

Comment 6 2011-10-24 02:42:53 PDT

Comment on attachment 112164 [details] patch Attachment 112164 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10200772

Zoltan Herczeg

Comment 7 2011-10-24 02:43:07 PDT

Created attachment 112165 [details] patch again

Dirk Schulze

Comment 8 2011-11-02 06:41:08 PDT

Comment on attachment 112165 [details] patch again View in context: https://bugs.webkit.org/attachment.cgi?id=112165&action=review LGTM. I can just trust you on the Neon code. Just some snippets. > Source/WebCore/ChangeLog:12 > + for all four RGBA channels in the same time. at the same time? > Source/WebCore/ChangeLog:13 > + Just mention that it won't affect the general behavior and existing tests will cover the changes. > Source/WebCore/platform/graphics/filters/FEComposite.cpp:123 > - float scaledK4; > - float scaledK1; > + float scaledK1, scaledK4; that is not allowed according the webkit style rules. Just leave it as it was. > Source/WebCore/platform/graphics/filters/FEComposite.cpp:180 > + ASSERT(!(pixelArrayLength & 0x3)); where is pixelArrayLength?

Zoltan Herczeg

Comment 9 2011-11-04 05:06:31 PDT

Landed in trac.webkit.org/changeset/99183 Closing bug.

Note You need to log in before you can comment on or make changes to this bug.