Bug 65510 – Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

<user feedback>

[Pavel Feldman]

Created attachment 102760 [details]
Patch

[WebKit Review Bot]

Comment on attachment 102760 [details]
Patch

Attachment 102760 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9300207

[Yury Semikhatsky]

Comment on attachment 102760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102760&action=review

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:303
> +void drawRectHighlight(GraphicsContext& context, Document* document, IntRect* rect)

Can we have a test for this functionality?

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:314
> +    static const Color fillColor(255, 0, 0, 20);

DEFINE_STATIC_LOCAL ?

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:316
> +    FloatRect floatRect = *rect;

Inline this?

> Source/WebCore/inspector/Inspector.json:1013
> +                    { "name": "x", "type": "integer", "description": "X coordinate" },

Please describe what is the origin for these coordinates.

> Source/WebCore/inspector/Inspector.json:1029
> +                "name": "hideHighlight",

Remove trailing comma or add a new description.

> Source/WebKit/mac/ChangeLog:3
> +        clean

Remove this.

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 102760 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102760&action=review
> 
> > Source/WebCore/inspector/DOMNodeHighlighter.cpp:303
> > +void drawRectHighlight(GraphicsContext& context, Document* document, IntRect* rect)
> 
> Can we have a test for this functionality?
> 

Not really. It is way too platform specific with no feedback to the front-end.

> > Source/WebCore/inspector/DOMNodeHighlighter.cpp:314
> > +    static const Color fillColor(255, 0, 0, 20);
> 
> DEFINE_STATIC_LOCAL ?
> 

Done.

> > Source/WebCore/inspector/DOMNodeHighlighter.cpp:316
> > +    FloatRect floatRect = *rect;
> 
> Inline this?
> 

Done.

> > Source/WebCore/inspector/Inspector.json:1013
> > +                    { "name": "x", "type": "integer", "description": "X coordinate" },
> 
> Please describe what is the origin for these coordinates.
> 

Done.

> > Source/WebCore/inspector/Inspector.json:1029
> > +                "name": "hideHighlight",
> 
> Remove trailing comma or add a new description.
> 

Done.

> > Source/WebKit/mac/ChangeLog:3
> > +        clean
> 
> Remove this.

Done.

[Pavel Feldman]

Created attachment 102788 [details]
Review comments addressed, to find out proper Mac symbol.

[WebKit Review Bot]

Comment on attachment 102788 [details]
Review comments addressed, to find out proper Mac symbol.

Attachment 102788 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9309008

[Pavel Feldman]

Committed r92284: <http://trac.webkit.org/changeset/92284>