Bug 65501

Summary:

Make the fullscreen JS API enabled at runtime.

Product:

WebKit

Reporter:

James Kozianski <koz>

Component:

New Bugs

Assignee:

James Kozianski <koz>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled	none
Patch	none
Patch	none

James Kozianski

Reported 2011-08-01 17:44:23 PDT

Make the fullscreen JS API enabled at runtime.

Attachments
Patch (7.03 KB, patch) 2011-08-01 17:45 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Patch (7.02 KB, patch) 2011-08-01 17:57 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Patch (7.10 KB, patch) 2011-08-01 23:26 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled (7.17 KB, patch) 2011-08-01 23:59 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Patch (7.20 KB, patch) 2011-08-07 17:31 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Patch (7.16 KB, patch) 2011-08-07 17:36 PDT, James Kozianski	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

James Kozianski

Comment 1 2011-08-01 17:45:08 PDT

Created attachment 102599 [details] Patch

James Kozianski

Comment 2 2011-08-01 17:57:07 PDT

Created attachment 102603 [details] Patch

James Kozianski

Comment 3 2011-08-01 23:26:51 PDT

Created attachment 102617 [details] Patch

James Kozianski

Comment 4 2011-08-01 23:59:20 PDT

Created attachment 102618 [details] Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled

James Kozianski

Comment 5 2011-08-04 00:02:42 PDT

Thanks Adam, could you take another look? I just made some minor changes. I was wondering about the etiquette / process for making slight changes like this. Should I have just cq+ed the new patch with minor changes instead of bothering you to take another look? (Would that have worked?)

Adam Barth

Comment 6 2011-08-04 00:17:03 PDT

Comment on attachment 102618 [details] Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled Generally, if you get an R+ with minor comments, that means you can land the patch (addressing those comments) without needing the reviewer to take another look. You can cq+ a patch even without the review flag, as long as you fill in the reviewer line in the ChangeLog manually. If you like, the "webkit-patch land-safely" command can fill in the reviewer line of the ChangeLog automatically and upload the patch with cq+ set.

WebKit Review Bot

Comment 7 2011-08-04 00:27:34 PDT

Comment on attachment 102618 [details] Minor changes, added WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled Rejecting attachment 102618 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: ISO C++ forbids declaration of 'WEBKIT_API' with no type out/Debug/obj/gen/webkit/third_party/WebKit/Source/WebKit/chromium/public/../../../../../../../../../../../Source/WebKit/chromium/public/WebRuntimeFeatures.h:110: error: expected ';' before 'static' CXX(target) out/Debug/obj.target/glue/Source/WebKit/chromium/webkit/glue/websocketstreamhandle_impl.o make: *** [out/Debug/obj.target/glue/Source/WebKit/chromium/webkit/glue/webpreferences.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/9300555

Adam Barth

Comment 8 2011-08-04 00:31:44 PDT

WEBKIT_API got renamed to WEBKIT_EXPORT while you weren't looking. :)

James Kozianski

Comment 9 2011-08-07 17:31:30 PDT

Created attachment 103189 [details] Patch

James Kozianski

Comment 10 2011-08-07 17:36:27 PDT

Created attachment 103190 [details] Patch

James Kozianski

Comment 11 2011-08-07 17:37:27 PDT

(In reply to comment #6) > (From update of attachment 102618 [details]) > Generally, if you get an R+ with minor comments, that means you can land the patch (addressing those comments) without needing the reviewer to take another look. You can cq+ a patch even without the review flag, as long as you fill in the reviewer line in the ChangeLog manually. If you like, the "webkit-patch land-safely" command can fill in the reviewer line of the ChangeLog automatically and upload the patch with cq+ set. Cool! Thanks for the tip :-)

WebKit Review Bot

Comment 12 2011-08-07 19:07:13 PDT

Comment on attachment 103190 [details] Patch Clearing flags on attachment: 103190 Committed r92576: <http://trac.webkit.org/changeset/92576>

WebKit Review Bot

Comment 13 2011-08-07 19:07:18 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.