Bug 65464

Summary:

[ORWT] Fix --reset-results --add-platform-exceptions combo

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

Tools / Tests

Assignee:

Kristóf Kosztyó <kkristof>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed fix	none

Description Csaba Osztrogonác 2011-08-01 04:51:55 PDT

I usually use ORWT with "-p --platform qt --reset-results --add-platform-exceptions"
options to create new and/or update Qt specific expected results for a bunch of tests.

Now if we use only --reset-results option,
 - platform independent expected result is reseted if there isn't platform specific result before (good)
 - platform specific expected result is reseted if there is platform specific result (good)

Now if we use only --add-platform-exceptions option,
 - platform specific expected result is be added if there isn't platform specific result (good)
 - nothing happens if there is platform specific result (maybe good)

Now if we use --add-platform-exceptions and --reset-results options,
 - platform independent expected result is reseted if there isn't platform specific result before ( <---- BUG!!! )
 - platform specific expected result is reseted if there is platform specific result (good)
 - platform specific expected result is added if there isn't platform specific result (good)

I run into a bug and/or feature. There are a bunch of tests need 
new and/or updated platform specific expected results:
 - tests with and without platform independent expected results
 - tests with and without platform specific expected results

It would be great if it is possible with ORWT to generate or reset all platform specific 
results with one run with --add-platform-exceptions and --reset-results options.

Comment 1 Csaba Osztrogonác 2011-08-01 06:09:36 PDT

There is a similar or same bug, when I use platform qt-4.8.

When I use --reset-results and --add-platform-exceptions combo and
there isn't qt-4.8 specific expected result, unfortunately the qt 
specific expected result will be resetted instead of the qt-4.8 one.

Comment 2 Kristóf Kosztyó 2011-08-07 23:47:26 PDT

Created attachment 103205 [details]
proposed fix

Comment 3 Csaba Osztrogonác 2011-08-22 03:05:44 PDT

Comment on attachment 103205 [details]
proposed fix

great work, r=me.

Comment 4 Csaba Osztrogonác 2011-08-22 03:06:19 PDT

Landed in https://trac.webkit.org/changeset/93502