Summary: | [Qt] Fix tst_QWebPage::loadHtml5Video() API test | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kristóf Kosztyó <kkristof> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | allan.jensen, hausmann, jturcotte, ossy, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 38654 | ||||||
Attachments: |
|
Description
Kristóf Kosztyó
2011-08-01 01:15:09 PDT
Created attachment 102489 [details]
mark failing test cases as expected fail
Comment on attachment 102489 [details]
mark failing test cases as expected fail
r=me
Comment on attachment 102489 [details] mark failing test cases as expected fail Rejecting attachment 102489 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/9285367 Comment on attachment 102489 [details] mark failing test cases as expected fail patch landed in https://trac.webkit.org/changeset/92115 Leave the bug open to fix it. This test is skipped now, because WTF_USE_QT_MULTIMEDIA is false. But WTF_USE_QT_MULTIMEDIA can be true only if contains(MOBILITY_CONFIG, multimedia). Qt Mobility was for Qt 4.8, QtMultimedia in Qt 5 integrates QtMultimedia from Qt 4.8 and Qt Multimedia Kit from Mobility - http://qt-project.org/doc/qt-5.0/changes.html So I think this code path is absolutely unreachable and unmaintained. Source/WebKit/qt/examples/platformplugin/platformplugin.pro: ------------------------------------------------------------- ... # HTML5 Media Support # We require QtMultimedia !contains(DEFINES, ENABLE_VIDEO=.) { contains(MOBILITY_CONFIG, multimedia) { CONFIG += mobility MOBILITY += multimedia DEFINES -= ENABLE_VIDEO=0 DEFINES += ENABLE_VIDEO=1 DEFINES -= WTF_USE_QT_MULTIMEDIA=0 DEFINES += WTF_USE_QT_MULTIMEDIA=1 } } ... === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. |