Bug 65441

Summary: Clean up value clamping in CSSStyleSelector and CSSPrimitiveValue.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, macpherson, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Luke Macpherson
Reported 2011-07-31 21:07:10 PDT
Clean up value clampling in CSSStyleSelector and CSSPrimitiveValue.
Attachments
Patch (4.91 KB, patch)
2011-07-31 21:10 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.91 KB, patch)
2011-08-02 18:02 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-07-31 21:10:08 PDT
Created attachment 102472 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-08-02 16:39:32 PDT
Comment on attachment 102472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102472&action=review > Source/WebCore/css/CSSStyleSelector.cpp:4511 > + m_style->setOpacity(clampTo<float>(primitiveValue->getDoubleValue(), 0.0, 1.0)); Won't this cause warnings in 64-bit builds? You don't need the .0 on the literals.
Luke Macpherson
Comment 3 2011-08-02 17:38:17 PDT
Comment on attachment 102472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102472&action=review >> Source/WebCore/css/CSSStyleSelector.cpp:4511 >> + m_style->setOpacity(clampTo<float>(primitiveValue->getDoubleValue(), 0.0, 1.0)); > > Won't this cause warnings in 64-bit builds? You don't need the .0 on the literals. done.
Luke Macpherson
Comment 4 2011-08-02 18:02:10 PDT
Created attachment 102725 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-08-02 19:11:23 PDT
Comment on attachment 102725 [details] Patch for landing Clearing flags on attachment: 102725 Committed r92253: <http://trac.webkit.org/changeset/92253>
WebKit Review Bot
Comment 6 2011-08-02 19:11:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.