Summary: | Clean up value clamping in CSSStyleSelector and CSSPrimitiveValue. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luke Macpherson <macpherson> | ||||||
Component: | New Bugs | Assignee: | Luke Macpherson <macpherson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin, eric, macpherson, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Luke Macpherson
2011-07-31 21:07:10 PDT
Created attachment 102472 [details]
Patch
Comment on attachment 102472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102472&action=review > Source/WebCore/css/CSSStyleSelector.cpp:4511 > + m_style->setOpacity(clampTo<float>(primitiveValue->getDoubleValue(), 0.0, 1.0)); Won't this cause warnings in 64-bit builds? You don't need the .0 on the literals. Comment on attachment 102472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102472&action=review >> Source/WebCore/css/CSSStyleSelector.cpp:4511 >> + m_style->setOpacity(clampTo<float>(primitiveValue->getDoubleValue(), 0.0, 1.0)); > > Won't this cause warnings in 64-bit builds? You don't need the .0 on the literals. done. Created attachment 102725 [details]
Patch for landing
Comment on attachment 102725 [details] Patch for landing Clearing flags on attachment: 102725 Committed r92253: <http://trac.webkit.org/changeset/92253> All reviewed patches have been landed. Closing bug. |