Bug 6544

Summary: Get rid of unused headers
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch hyatt: review+

Anders Carlsson
Reported 2006-01-14 17:53:47 PST
I have a patch that removes a couple of headers that aren't really used
Attachments
Patch (30.81 KB, patch)
2006-01-14 17:58 PST, Anders Carlsson 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2006-01-14 17:58:20 PST
Created attachment 5683 [details] Patch
Dave Hyatt
Comment 2 2006-01-14 18:04:17 PST
Comment on attachment 5683 [details] Patch r=me
Eric Seidel (no email)
Comment 3 2006-01-14 18:05:13 PST
Comment on attachment 5683 [details] Patch Looks good. I suggested adding a comment for this line: - QFont f = KGlobalSettings::generalFont(); + QFont f; Since the original intention of the code was to actually get a generic font... now we're just pulling the defaults out of QFont(). heck, one could just change khtml::FontDef fontDef to have the proper defaults and remove all that code. r=me.
Note You need to log in before you can comment on or make changes to this bug.