Remove LegacyDefaultOptionalArguments flag from navigator IDL files

• Component: New Bugs
• Status: RESOLVED FIXED

[Mark Pilgrim (Google)]

As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates navigator-related files. This patch changes behavior -- it makes the registerProtocolHandler match Firefox's behavior by making all arguments required and throwing TypeError if required arguments are missing. It also adjusts an existing test to check for the TypeError.

[Mark Pilgrim (Google)]

Created attachment 102354 [details]
Patch

[WebKit Review Bot]

Comment on attachment 102354 [details]
Patch

Attachment 102354 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9266501

New failing tests:
fast/dom/navigator-detached-no-crash.html

[Adam Barth]

Comment on attachment 102354 [details]
Patch

Can you check how registerProtocolHandler works in other browsers?  I'd expect folks might leave off the "title" attribute.

[Adam Barth]

Comment on attachment 102354 [details]
Patch

Looks like you're failing a test.

[Mark Pilgrim (Google)]

Firefox throws NOT_ENOUGH_ARGUMENTS exception if any argument is missing, including title.

[Adam Barth]

(In reply to comment #5)
> Firefox throws NOT_ENOUGH_ARGUMENTS exception if any argument is missing, including title.

Great.  Thanks for checking.  Maybe add a test to that effect?

[Mark Pilgrim (Google)]

Created attachment 102821 [details]
Patch

[WebKit Review Bot]

Comment on attachment 102821 [details]
Patch

Clearing flags on attachment: 102821

Committed r92315: <http://trac.webkit.org/changeset/92315>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

fast/dom/navigator-detached-no-crash.html started failing on Qt after this patch:
http://build.webkit.org/results/Qt%20Linux%20Release/r92315%20(36108)/fast/dom/navigator-detached-no-crash-pretty-diff.html

[Adam Barth]

That makes very little sense.  Maybe I'm confused.

[Ryosuke Niwa]

The same test is failing on Snow Leopard and GTK as well:
http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r92315%20(1501)/fast/dom/navigator-detached-no-crash-pretty-diff.html
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r92316%20(16215)/fast/dom/navigator-detached-no-crash-pretty-diff.html

[Ryosuke Niwa]

I don't think registerProtocolHandler is enabled on any port but chromium.  I'll just revert http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt?rev=92315

[Ryosuke Niwa]

Done in http://trac.webkit.org/changeset/92338.