Bug 65354

Summary: [chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 easier to review
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, kbr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 58840    
Attachments:
Description Flags
Patch kbr: review+, webkit.review.bot: commit-queue-

James Robinson
Reported 2011-07-28 19:19:45 PDT
[chromium] Reorder functions in LayerRendererChromium.cpp to make bug 58840 easier to review
Attachments
Patch (32.35 KB, patch)
2011-07-28 19:21 PDT, James Robinson 		kbr: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-07-28 19:21:07 PDT
Created attachment 102324 [details] Patch
James Robinson
Comment 2 2011-07-28 19:21:39 PDT
This just shuffles code around but doesn't change anything else.
Adrienne Walker
Comment 3 2011-07-29 11:08:13 PDT
(In reply to comment #2) > This just shuffles code around but doesn't change anything else. This seems quite straightforward. I'll unofficially give it my ok.
Kenneth Russell
Comment 4 2011-07-29 15:19:01 PDT
Comment on attachment 102324 [details] Patch OK.
WebKit Review Bot
Comment 5 2011-07-29 16:19:13 PDT
Comment on attachment 102324 [details] Patch Rejecting attachment 102324 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1 Last 500 characters of output: 4647d77504c0e855c57bbcaec87f101517e229b6 r92030 = 407c10b1dc3e2cf898131dfc12ff4a89ecd8b615 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9264646
James Robinson
Comment 6 2011-07-29 16:25:06 PDT
I fail so hardcore at ChangeLogs :(
James Robinson
Comment 7 2011-07-29 18:26:17 PDT
Committed r92037: <http://trac.webkit.org/changeset/92037>
Note You need to log in before you can comment on or make changes to this bug.