Summary: | CJK input broken after clicking on Flash content | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | Plug-ins | Assignee: | Tim Horton <thorton> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, ap, darin, freshworks, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2011-07-28 16:29:29 PDT
Created attachment 102311 [details]
patch
Comment on attachment 102311 [details] patch Rejecting attachment 102311 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1 Last 500 characters of output: eLog M Source/WebKit2/Shared/FontInfo.cpp M Source/WebKit2/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm r91961 = c8c9ff84269378e6e74c1a17182ca2426ec5bf38 (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9265319 Created attachment 102314 [details]
patch
Bot output is odd, but I somehow deleted the Reviewed by line.
Comment on attachment 102314 [details] patch Clearing flags on attachment: 102314 Committed r91964: <http://trac.webkit.org/changeset/91964> All reviewed patches have been landed. Closing bug. Comment on attachment 102314 [details]
patch
What will fix text input if the plugin view goes into back/forward cache without being deleted?
Good point. I don’t think the destructor is the right place to put this code. I didn’t actually look at the patch. I just reviewed so the commit-bot would work. Anders was the actual reviewer. Indeed, and I've just Cc'd Anders. I got the impression from him that this was the right place to put it (I went into his office with no idea where to put it), but Alexey's point is definitely valid (and something I hadn't considered). I'll talk to him again tomorrow and see about better options. Well, the answer is that pages with plug-ins never go into b/f cache. But we want to fix that, and there is nothing to remind us that this bug needs to be revisited when doing so. *** Bug 65892 has been marked as a duplicate of this bug. *** |