Bug 65331

Summary: Web Inspector: [protocol] methods where all parameters are optional should not require empty params object.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Pavel Feldman
Reported 2011-07-28 11:36:24 PDT
Patch to follow.
Attachments
Patch (8.02 KB, patch)
2011-07-28 11:41 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-07-28 11:41:32 PDT
Created attachment 102277 [details] Patch
Yury Semikhatsky
Comment 2 2011-07-31 23:22:50 PDT
Comment on attachment 102277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102277&action=review > Source/WebCore/inspector/CodeGeneratorInspector.pm:599 > + protocolErrors->pushString(String::format("'params' object should contain required parameter '\%s' with type '$json'.", name.utf8().data())); should -> must?
Pavel Feldman
Comment 3 2011-08-01 01:14:11 PDT
Committed r92104: <http://trac.webkit.org/changeset/92104>
Note You need to log in before you can comment on or make changes to this bug.