Bug 65280 – [Chromium] Remove the parameterless WebFrame::createAssociatedURLLoader overload.

• Component: Platform
• Status: RESOLVED FIXED

[Bill Budge]

Remove the original createAssociatedURLLoader method that takes no options. The new overload, with default constructed WebURLLoaderOptions is equivalent.

[Bill Budge]

Created attachment 102182 [details]
Proposed Patch

[Bill Budge]

Comment on attachment 102182 [details]
Proposed Patch

I need to confirm that this doesn't break Chromium tests.

[David Levin]

Seems fine. (Ideally the text in the change log would be wrapped but not a huge deal.)

Needs Darin Fisher's approval due to change in Source/WebKit/chromium/public/WebFrame.h

[Bill Budge]

Created attachment 102203 [details]
Proposed Patch

Fixed Changelog to not wrap.
Chromium trys of changeover to new method show no problems.

[WebKit Review Bot]

Comment on attachment 102203 [details]
Proposed Patch

Attachment 102203 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9262088

New failing tests:
http/tests/canvas/webgl/origin-clean-conformance.html
http/tests/media/video-cookie.html
http/tests/security/local-video-source-from-remote.html
http/tests/media/video-referer.html

[WebKit Review Bot]

Comment on attachment 102203 [details]
Proposed Patch

Rejecting attachment 102203 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
e.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE

Regressions: Unexpected tests timed out : (3)
  http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT
  http/tests/media/video-cookie.html = TIMEOUT
  http/tests/security/local-video-source-from-remote.html = TIMEOUT

Regressions: Unexpected image and text mismatch : (1)
  svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT



Full output: http://queues.webkit.org/results/9266627

[Bill Budge]

I looked at the output and the errors seem unrelated to this patch. Can we try again?

[Adam Barth]

Comment on attachment 102203 [details]
Proposed Patch

Sure.

[WebKit Review Bot]

Comment on attachment 102203 [details]
Proposed Patch

Rejecting attachment 102203 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE

Regressions: Unexpected tests timed out : (3)
  http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT
  http/tests/media/video-cookie.html = TIMEOUT
  http/tests/security/local-video-source-from-remote.html = TIMEOUT

Regressions: Unexpected text diff mismatch : (1)
  http/tests/media/video-referer.html = TEXT



Full output: http://queues.webkit.org/results/9286036

[Adam Barth]

We've got the same result three times now.  I suspect it's caused by your patch in some way.  Feel free to land manually, but I suspect you'll just make the error show up on the bots.

[Bill Budge]

Thanks Adam. It depends on a Chromium patch http://src.chromium.org/viewvc/chrome?view=rev&revision=94675 but I think by now that must be available for these tests. Am I missing something here?

[Adam Barth]

(In reply to comment #11)
> Thanks Adam. It depends on a Chromium patch http://src.chromium.org/viewvc/chrome?view=rev&revision=94675 but I think by now that must be available for these tests. Am I missing something here?

http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS#L35

  'chromium_rev': '94403'

Looks like WebKit doesn't see that revision yet.  We can roll those DEPS though.

[Adam Barth]

Chromium DEPS roll in https://bugs.webkit.org/show_bug.cgi?id=65423

[David Levin]

Comment on attachment 102203 [details]
Proposed Patch

Since deps has been rolled....

[Adam Barth]

Comment on attachment 102203 [details]
Proposed Patch

Hasn't quite landed yet.  :)

[David Levin]

Comment on attachment 102203 [details]
Proposed Patch

whoops.

[WebKit Review Bot]

Comment on attachment 102203 [details]
Proposed Patch

Clearing flags on attachment: 102203

Committed r92083: <http://trac.webkit.org/changeset/92083>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.