Bug 65177

Summary:

[GTK] Remove header webkitwebviewcommon.h

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch	none

Carlos Garcia Campos

Reported 2011-07-26 05:56:06 PDT

Now that we have decided to create a webkit2 GTK api from scratch, that doesn't depend on webkit1 api, we can revert part of r88631 and remove the use of webkitwebviewcommon.h header.

Attachments
Patch (7.33 KB, patch) 2011-07-26 05:59 PDT, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Patch (7.37 KB, patch) 2011-07-26 06:38 PDT, Carlos Garcia Campos	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2011-07-26 05:59:31 PDT

Created attachment 101991 [details] Patch

WebKit Review Bot

Comment 2 2011-07-26 06:02:37 PDT

Attachment 101991 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:63: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:66: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 8 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Carlos Garcia Campos

Comment 3 2011-07-26 06:34:08 PDT

(In reply to comment #2) > Attachment 101991 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:63: Extra space before ( in function call [whitespace/parens] [4] > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:66: Extra space before ( in function call [whitespace/parens] [4] > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: Extra space before ( in function call [whitespace/parens] [4] > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: Extra space before ( in function call [whitespace/parens] [4] > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: Extra space before ( in function call [whitespace/parens] [4] > Total errors found: 8 in 5 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. https://bugs.webkit.org/show_bug.cgi?id=65179

Carlos Garcia Campos

Comment 4 2011-07-26 06:38:23 PDT

Created attachment 101995 [details] Patch Sorry, I removed the 'Reviewed by' line by mistake from one fo the changelog entries.

WebKit Review Bot

Comment 5 2011-07-26 06:41:28 PDT

Attachment 101995 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:63: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:66: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:69: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:73: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: The parameter name "webView" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 8 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 6 2011-07-26 07:55:46 PDT

Comment on attachment 101995 [details] Patch Clearing flags on attachment: 101995 Committed r91755: <http://trac.webkit.org/changeset/91755>

WebKit Review Bot

Comment 7 2011-07-26 07:55:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.