Bug 65173

Summary: Use AtomicString as return value for SVGURIReference::getTarget()
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebCore Misc.Assignee: Patrick R. Gansterer <paroga>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, annevk, bfulgham, dbates, krit, rwlbuis, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 65172    
Attachments:
Description Flags
Patch bfulgham: review+, paroga: commit-queue-

Patrick R. Gansterer
Reported 2011-07-26 04:35:08 PDT
Use AtomicString as return value for SVGURIReference::getTarget()
Attachments
Patch (8.63 KB, patch)
2011-07-26 04:42 PDT, Patrick R. Gansterer 		bfulgham: review+
paroga: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-07-26 04:42:15 PDT
Created attachment 101985 [details] Patch
Brent Fulgham
Comment 2 2011-11-10 09:57:41 PST
Comment on attachment 101985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101985&action=review Looks good to me. Build bots seem happy, so let's r+ it. > Source/WebCore/ChangeLog:8 > + Use AtomicString instead of String to avoid unnecessary type conversations. I think you mean "type conversions" here. ;-) > Source/WebCore/rendering/svg/SVGResources.cpp:142 > if (element->hasTagName(SVGNames::patternTag)) It would be neat if the href calls in the implementation returned AtomicStrings as well, but that would be a much bigger change! :-)
Ahmad Saleem
Comment 3 2022-10-05 16:10:10 PDT
It seems this r+ patch didn't landed. Do we need this anymore? Thanks!
Anne van Kesteren
Comment 4 2023-12-28 10:35:05 PST
This appears to have been refactored already.
Note You need to log in before you can comment on or make changes to this bug.