Bug 65134
| Summary: | REGRESSION: r91699 broke some font tests (image+text) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrienne Walker <enne> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andersca, enne, mitz |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrienne Walker
See this link for a list of tests and results:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=fast/blockflow/broken-ideograph-small-caps.html,fast/css/color-leakage.html,fast/css/font-face-multiple-faces.html,fast/css/font-face-multiple-remote-sources.html,fast/css/font-face-remote.html,fast/css/font-face-woff.html,svg/W3C-SVG-1.1/fonts-elem-07-b.svg,svg/custom/svg-fonts-fallback.xhtml,svg/custom/svg-fonts-in-html.html,svg/custom/svg-fonts-segmented.xhtml,svg/custom/svg-fonts-with-no-element-reference.html,svg/custom/svg-fonts-without-missing-glyph.xhtml,svg/text/text-overflow-ellipsis-svgfont.html,svg/W3C-SVG-1.1-SE/text-intro-09-b.svg,fast/css/custom-font-xheight.html
The SVG tests at least are broken on both Safari and Chromium. In particular, the rendering of fonts appears to disappear and the font metrics are different after this change.
Is this easily fixable? Would it make more sense to revert until you can address these issues?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
mitz
Looks like the tests would need to have a small delay built into them in order to account for loading being asynchronous even in the cached and error cases.
mitz
I reverted r91699 in <http://trac.webkit.org/r91710>.