Bug 6508

Summary:

retire APPLE_CHANGES

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Enhancement

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
removes all remaining use of APPLE_CHANGES	none
remove all remaining APPLE_CHANGES (tested, unlike previous try)	none
third try -- this time for sure	hyatt: review+

Darin Adler

Reported 2006-01-12 09:09:29 PST

APPLE_CHANGES should go, it's history. We use __APPLE__ for Mac-OS-X specific things and WIN32 for Windows-specific things.

Attachments
removes all remaining use of APPLE_CHANGES (16.50 KB, patch) 2006-01-12 09:20 PST, Darin Adler	no flags	Details Formatted Diff Diff
remove all remaining APPLE_CHANGES (tested, unlike previous try) (16.50 KB, patch) 2006-01-12 09:24 PST, Darin Adler	no flags	Details Formatted Diff Diff
third try -- this time for sure (17.59 KB, patch) 2006-01-12 09:55 PST, Darin Adler	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2006-01-12 09:20:40 PST

Created attachment 5621 [details] removes all remaining use of APPLE_CHANGES

Darin Adler

Comment 2 2006-01-12 09:24:24 PST

Created attachment 5622 [details] remove all remaining APPLE_CHANGES (tested, unlike previous try)

Darin Adler

Comment 3 2006-01-12 09:30:35 PST

Comment on attachment 5622 [details] remove all remaining APPLE_CHANGES (tested, unlike previous try) Still not quite right. I'll put in a new patch soon.

Darin Adler

Comment 4 2006-01-12 09:55:29 PST

Created attachment 5623 [details] third try -- this time for sure

Dave Hyatt

Comment 5 2006-01-13 00:01:20 PST

Comment on attachment 5623 [details] third try -- this time for sure r=me

Note You need to log in before you can comment on or make changes to this bug.