Bug 65064

Summary: Don't use group separators in formatting input[type=number]
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: shinyak, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62939    
Attachments:
Description Flags
Patch none

Description Shinya Kawanaka 2011-07-23 06:48:09 PDT
The current implementation of WebKit inserts commas (or period in fr_FR environment etc.) for formatting input[type=number].
This is not comfortable in some situations, so commas should not be inserted for formatting input[type=number]. However, the input[type=number] should accept numbers with commas.

NOTE: This bug is intended to fix only some aspects of bug 62939.
Comment 1 Shinya Kawanaka 2011-07-23 07:44:16 PDT
Created attachment 101810 [details]
Patch
Comment 2 Kent Tamura 2011-07-23 08:22:35 PDT
Comment on attachment 101810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101810&action=review

The patch have some issues.  But I think it's ok to land this.

> LayoutTests/ChangeLog:3
> +        Marked fast/speech/input-appearance-numberandspeech.html flaky on Mac and Windows.

No.  It won't be flaky on Mac and Windows.
Flaky means that the result of a test is not stable without any change related to the test. In this case, we expect the test will fail by this change. So the test expectation should be:
  BUGWK65064 WIN MAC : fast/speech/input-appearance-numberandspeech.html = FAIL

> LayoutTests/platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:164
>  layer at (14,48) size 81x10 scrollWidth 172

This file is not listed in LayoutTests/ChangeLog.
Also, we should not update a render tree dump without updating the corresponding PNG in Chromium port.
Comment 3 WebKit Review Bot 2011-07-23 09:21:27 PDT
Comment on attachment 101810 [details]
Patch

Clearing flags on attachment: 101810

Committed r91636: <http://trac.webkit.org/changeset/91636>
Comment 4 WebKit Review Bot 2011-07-23 09:21:31 PDT
All reviewed patches have been landed.  Closing bug.