Bug 64995

Summary: Web Inspector: [REGRESSION r89960-r91561] inconsistent state for Scripts panel, not paused but paused.
Product: WebKit Reporter: johnjbarton <johnjbarton>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 65078    
Bug Blocks:    
Attachments:
Description Flags
screen shot of WebInspector ui
none
Patch yurys: review+

Description johnjbarton 2011-07-21 16:55:48 PDT
Created attachment 101667 [details]
screen shot of WebInspector ui

file:///home/johnjbarton/Downloads/image.png
Comment 1 johnjbarton 2011-07-21 17:02:47 PDT
http://code.google.com/p/traceur-compiler/wiki/EnlistingAndTesting

1. svn co https://traceur-compiler.googlecode.com/svn
2. run chrome browser with command line option  --allow-file-access-from-files 
3. open file url for svn/example/hello.html
4. open Web Inspector, Script panel
5. set breakpoint on line 105 
 results.keys().forEach(function(file) {
and 107
var result = traceur.codegeneration.ParseTreeWriter.write(tree, false);
6. reload, you should hit 105
7. click continue 

Now you are not paused according to Scope Vars and yet the app is not making progress.

If you click continue again it finishes.
Comment 2 Pavel Feldman 2011-07-22 02:21:01 PDT
Front-end exception:

Uncaught TypeError: Cannot read property 'sourceURL' of undefined
WebInspector.DebuggerPresentationModel._sourceFileForScriptDebuggerPresentationModel.js:621
WebInspector.DebuggerPresentationModel._scriptLocationToUILocationDebuggerPresentationModel.js:89
WebInspector.PresenationCallFrame.sourceLineDebuggerPresentationModel.js:784
WebInspector.CallStackSidebarPane.updateCallStackSidebarPane.js:71
WebInspector.ScriptsPanel._debuggerPausedScriptsPanel.js:405
WebInspector.Object.dispatchEventToListenersObject.js:90
WebInspector.DebuggerPresentationModel._debuggerPausedDebuggerPresentationModel.js:594
WebInspector.Object.dispatchEventToListenersObject.js:90
WebInspector.DebuggerModel._pausedScriptDebuggerModel.js:175
WebInspector.DebuggerDispatcher.pausedDebuggerModel.js:214
InspectorBackendStub.dispatch
Comment 3 Pavel Podivilov 2011-07-22 07:42:53 PDT
Created attachment 101731 [details]
Patch
Comment 4 Yury Semikhatsky 2011-07-22 07:56:16 PDT
Comment on attachment 101731 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101731&action=review

> LayoutTests/http/tests/inspector/debugger-test.js:118
> +            lineNumber = "(line number)";

Consider living it undefined.

> LayoutTests/inspector/debugger/pause-in-internal-script.html:21
> +    InspectorTest.runDebuggerTestSuite([

You don't need runDebuggerTestSuite, just inline testSetBreakpoint body here.

> LayoutTests/inspector/debugger/pause-in-internal-script.html:47
> +<p>Tests that internal scripts unknown to front-end are processed correctly when appear in debugger call frames.

Link to the bug?
Comment 5 Pavel Podivilov 2011-07-22 08:29:29 PDT
Committed r91568: <http://trac.webkit.org/changeset/91568>