Bug 64932 – [EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Grzegorz Czajkowski]

It prevents the crash while allocating a memory for the new window.

[Grzegorz Czajkowski]

Created attachment 101569 [details]
proposed patch

[Raphael Kubo da Costa (:rakuco)]

Did this actually happen to you when you were doing some tests, or is this a hypothetical case?

> Source/WebKit/efl/ChangeLog:3
> +        [EFL] Added NULL cheking in ewk_window_features_new_from_core and ewk_view_window_create.

checking -> checking

In general, these descriptions are in the present tense, so it might be better phrased as "Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create".

> Source/WebKit/efl/ChangeLog:6
> +        It prevents the crash while allocating a memory for the new window.

the -> a
a memory -> memory

[Grzegorz Czajkowski]

(In reply to comment #2)
> Did this actually happen to you when you were doing some tests, or is this a hypothetical case?
> 
This is a hypothetical case:) Generally we check malloc (and friend) returned value in WebKit-EFL. Just this is one them :)

[Grzegorz Czajkowski]

Created attachment 101584 [details]
updated patch

Fixed patch according to Raphael's suggestions.

[Raphael Kubo da Costa (:rakuco)]

r+ from my side.

[Grzegorz Czajkowski]

(In reply to comment #3)
> (In reply to comment #2)
> > Did this actually happen to you when you were doing some tests, or is this a hypothetical case?
> > 
> This is a hypothetical case:) Generally we check malloc (and friend) returned value in WebKit-EFL. Just this is one them :)

One more thing. This is one of important defects in WebKit-EFL which was found by static analysis tools. These tools sometimes provide not reliable data. We should appraise whether this defect is really bug for us or not :) I think we should fix it in this case.

[Gyuyoung Kim]

Comment on attachment 101584 [details]
updated patch

LGTM. I think this patch needs to be landed.

[Eric Seidel (no email)]

Comment on attachment 101584 [details]
updated patch

rs=me.

[WebKit Review Bot]

Comment on attachment 101584 [details]
updated patch

Rejecting attachment 101584 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ebKit/efl/ewk/ewk_view.cpp
Hunk #1 succeeded at 2864 (offset -809 lines).
Hunk #2 FAILED at 3685.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_view.cpp.rej
patching file Source/WebKit/efl/ewk/ewk_window_features.cpp
Hunk #1 FAILED at 150.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_window_features.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9648315

[Grzegorz Czajkowski]

Created attachment 107321 [details]
proposed patch

Patch has been re-based.

[Gyuyoung Kim]

Comment on attachment 107321 [details]
proposed patch

LGTM.

[WebKit Review Bot]

Comment on attachment 107321 [details]
proposed patch

Clearing flags on attachment: 107321

Committed r95088: <http://trac.webkit.org/changeset/95088>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.