Bug 64905

Summary: Set DrawingBuffer's context's parent before publishing its backing store to the parent.
Product: WebKit Reporter: Al <apatrick>
Component: WebCore Misc.Assignee: Al <apatrick>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch 1
none
Patch 2 none

Al
Reported 2011-07-20 16:55:23 PDT
[chromium] Set DrawingBuffer's context's parent before publishing its backing store to the parent. This allows accelerated 2D canvas elements to be moved between windows.
Attachments
Patch 1 (1.38 KB, patch)
2011-07-20 16:58 PDT, Al 		no flags
DetailsFormatted DiffDiff
Patch 2 (2.21 KB, patch)
2011-07-20 18:11 PDT, Al 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Al
Comment 1 2011-07-20 16:58:03 PDT
Created attachment 101528 [details] Patch 1
Al
Comment 2 2011-07-20 17:12:31 PDT
The comment isn't exactly accurate. This patch allows an accelerated 2D canvas to be created in a newly opened windows but not moved from one to another.
James Robinson
Comment 3 2011-07-20 17:19:24 PDT
Comment on attachment 101528 [details] Patch 1 Why are you calling platformTexture()? If you just want m_context to be current, how about calling makeContextCurrent()?
Al
Comment 4 2011-07-20 17:28:58 PDT
(In reply to comment #3) > (From update of attachment 101528 [details]) > Why are you calling platformTexture()? If you just want m_context to be current, how about calling makeContextCurrent()? GraphicsContext3DChromium::platformTexture sets the context's parent to that of the associated view. It also returns the texture ID in the context of that parent but that is not used for 2D canvas.
Al
Comment 5 2011-07-20 18:11:11 PDT
Created attachment 101540 [details] Patch 2
Al
Comment 6 2011-07-20 18:11:54 PDT
Updated patch as discussed with jamesr.
James Robinson
Comment 7 2011-07-20 18:14:21 PDT
Comment on attachment 101540 [details] Patch 2 Great! R=me
WebKit Review Bot
Comment 8 2011-07-20 19:47:09 PDT
Comment on attachment 101540 [details] Patch 2 Clearing flags on attachment: 101540 Committed r91441: <http://trac.webkit.org/changeset/91441>
WebKit Review Bot
Comment 9 2011-07-20 19:47:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.