Summary: | Wrong URL loaded into child frame after back/forward navigation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nate Chapin <japhet> | ||||||
Component: | WebCore Misc. | Assignee: | Nate Chapin <japhet> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, mihaip, webkit.review.bot, xt6.thomas.genin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Nate Chapin
2011-07-20 14:11:11 PDT
Created attachment 101509 [details]
patch
Comment on attachment 101509 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=101509&action=review Is the current behavior (that the URL is restored for iframes for back-forward navigations) tested anywhere? > LayoutTests/fast/loader/child-frame-add-after-back-forward.html:9 > + layoutTestController.overridePreference('WebKitUsesPageCachePreferenceKey', 0); You may want to add an unload handler too, so that the page cache is disabled when running the test in Safari too. (In reply to comment #2) > (From update of attachment 101509 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=101509&action=review > > Is the current behavior (that the URL is restored for iframes for back-forward navigations) tested anywhere? Yeah, if I comment out the if() statement and everything inside, 2 tests each in fast/history and http/tests/navigation fail. > > > LayoutTests/fast/loader/child-frame-add-after-back-forward.html:9 > > + layoutTestController.overridePreference('WebKitUsesPageCachePreferenceKey', 0); > > You may want to add an unload handler too, so that the page cache is disabled when running the test in Safari too. Good point. Created attachment 101743 [details]
Patch for landing
Comment on attachment 101743 [details] Patch for landing Clearing flags on attachment: 101743 Committed r91583: <http://trac.webkit.org/changeset/91583> All reviewed patches have been landed. Closing bug. |