Document mouseover event reporting incorrect mouse button

• Component: UI Events
• Status: RESOLVED FIXED

[Scott Graham]

In events received by a mouseover handler, event.which should be 0 when no mouse button is held down.

When no mouse button is held down, event.which is instead 1, indicating that the left mouse button is held, even though it isn't.

See also http://code.google.com/p/chromium/issues/detail?id=87473

[Scott Graham]

Created attachment 101493 [details]
report correct .which when button isn't down

[Eric Seidel (no email)]

Comment on attachment 101493 [details]
report correct .which when button isn't down

View in context: https://bugs.webkit.org/attachment.cgi?id=101493&action=review

OK.  Seems fine.

> LayoutTests/fast/events/mouseover-button-expected.txt:7
> +mouseover on frame1
> +mouseover on t6 which: 0
> +mouseover on t6 which: 1
> +mouseover on t6 which: 0
> +mouseover on t6 which: 2

These woudl be better with PASS/FAIL, etc.  js-test-pre.js can help you by giving you a shouldBe function, etc.

> LayoutTests/fast/events/mouseover-button.html:19
> +<a href="http://code.google.com/p/chromium/issues/detail?id=87473">cr 87473</a>

webkit bug?

[Scott Graham]

Created attachment 101520 [details]
fix test code per comments

[Eric Seidel (no email)]

Comment on attachment 101520 [details]
fix test code per comments

LGTM.

[WebKit Review Bot]

Comment on attachment 101520 [details]
fix test code per comments

Clearing flags on attachment: 101520

Committed r91416: <http://trac.webkit.org/changeset/91416>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

The test added by this patch is failing on Mac and Windows ports because they don't keep track of which buttons were pressed.  We should either skip this test on those ports or move the test into platform/chromium.

[Scott Graham]

Created attachment 101619 [details]
disable test on mac/win

[WebKit Review Bot]

Attachment 101619 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:3:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Scott Graham]

Created attachment 101621 [details]
disable test on mac/win

[WebKit Review Bot]

Attachment 101621 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Scott Graham]

Created attachment 101622 [details]
disable test on mac/win

[Ryosuke Niwa]

Comment on attachment 101622 [details]
disable test on mac/win

Clearing flags on attachment: 101622

Committed r91484: <http://trac.webkit.org/changeset/91484>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.