Bug 64775

Summary: webkit-patch rebaseline crashes on use
Product: WebKit Reporter: Sam Weinig <sam>
Component: Tools / TestsAssignee: Sam Weinig <sam>
Severity: Normal CC: abarth, aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch aroben: review+

Description Sam Weinig 2011-07-18 19:48:57 PDT
When trying to rebaseline the Leopard machines, webkit-patch crashes:

:-( weinig@il0301a-dhcp72:.../OpenSource/LayoutTests> webkit-patch rebaseline
16 builders failing
Which builder to pull results from:
 1. Leopard Intel Release (Tests)
 2. Leopard Intel Debug (Tests)
 3. SnowLeopard Intel Release (Tests)
 4. SnowLeopard Intel Debug (Tests)
 5. SnowLeopard Intel Leaks
 6. SnowLeopard Intel Release (WebKit2 Tests)
 7. SnowLeopard Intel Debug (WebKit2 Tests)
 8. Windows 7 Release (Tests)
 9. Windows XP Debug (Tests)
10. Windows 7 Release (WebKit2 Tests)
11. GTK Linux 32-bit Release
12. GTK Linux 32-bit Debug
13. GTK Linux 64-bit Debug
14. Qt Linux Release
15. SnowLeopard Intel Release (NRWT)
16. CSSRegions SnowLeopard Intel Release (Build)
Enter a number: 1
Traceback (most recent call last):
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkit-patch", line 66, in <module>
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkit-patch", line 61, in main
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 165, in execute
    for test in self._tests_to_update(build):
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 152, in _tests_to_update
    failing_tests = build.layout_test_results().tests_matching_failure_types([test_failures.FailureTextMismatch])
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 167, in tests_matching_failure_types
    return [result.filename for result in self.results_matching_failure_types(failure_types)]
AttributeError: 'TestResult' object has no attribute 'filename'
Comment 1 Sam Weinig 2011-07-19 08:48:18 PDT
Created attachment 101324 [details]
Comment 2 Adam Roben (:aroben) 2011-07-19 08:56:13 PDT
Comment on attachment 101324 [details]

No test!?!?!?!?
Comment 3 Sam Weinig 2011-07-19 09:09:51 PDT
Created attachment 101328 [details]
Comment 4 Sam Weinig 2011-07-19 09:13:39 PDT
Committed r91261: <http://trac.webkit.org/changeset/91261>