Bug 64775 – webkit-patch rebaseline crashes on use

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Sam Weinig]

When trying to rebaseline the Leopard machines, webkit-patch crashes:

:-( weinig@il0301a-dhcp72:.../OpenSource/LayoutTests> webkit-patch rebaseline
16 builders failing
Which builder to pull results from:
 1. Leopard Intel Release (Tests)
 2. Leopard Intel Debug (Tests)
 3. SnowLeopard Intel Release (Tests)
 4. SnowLeopard Intel Debug (Tests)
 5. SnowLeopard Intel Leaks
 6. SnowLeopard Intel Release (WebKit2 Tests)
 7. SnowLeopard Intel Debug (WebKit2 Tests)
 8. Windows 7 Release (Tests)
 9. Windows XP Debug (Tests)
10. Windows 7 Release (WebKit2 Tests)
11. GTK Linux 32-bit Release
12. GTK Linux 32-bit Debug
13. GTK Linux 64-bit Debug
14. Qt Linux Release
15. SnowLeopard Intel Release (NRWT)
16. CSSRegions SnowLeopard Intel Release (Build)
Enter a number: 1
Traceback (most recent call last):
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkit-patch", line 66, in <module>
    main()
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkit-patch", line 61, in main
    WebKitPatch(__file__).main()
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 165, in execute
    for test in self._tests_to_update(build):
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 152, in _tests_to_update
    failing_tests = build.layout_test_results().tests_matching_failure_types([test_failures.FailureTextMismatch])
  File "/Volumes/Data/Lion/Users/weinig/Code/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 167, in tests_matching_failure_types
    return [result.filename for result in self.results_matching_failure_types(failure_types)]
AttributeError: 'TestResult' object has no attribute 'filename'

[Sam Weinig]

Created attachment 101324 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 101324 [details]
Patch

No test!?!?!?!?

[Sam Weinig]

Created attachment 101328 [details]
Patch

[Sam Weinig]

Committed r91261: <http://trac.webkit.org/changeset/91261>