Summary: | DFG JIT sometimes emits spill code even when the respective values are never needed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, fpizlo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2011-07-18 19:05:47 PDT
Created attachment 101268 [details]
the patch
Comment on attachment 101268 [details]
the patch
Per our last discussion I'd quite like to refactor this to make the RAII pattern a little more useful here, and try to make some of this more automatic - but we already have the issue of requiring that gpr() is called at the right point, and this all looks fine.
Comment on attachment 101268 [details] the patch Clearing flags on attachment: 101268 Committed r91280: <http://trac.webkit.org/changeset/91280> All reviewed patches have been landed. Closing bug. |