Bug 64744

Summary:

[Cairo] Switch from ContextShadow to ShadowBlur

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

Layout and Rendering

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, ariya.hidayat, dbates, dglazkov, gustavo, krit, simon.fraser, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

65035

Attachments:

Description	Flags
Patch	none
Patch rebased to master and with a aliasing fix	none
Patch fixing EFL build	none
Fix GTK+ and EFL build	krit: review+

Description Martin Robinson 2011-07-18 13:08:30 PDT

Qt recently switched away from ContextShadow to ShadowBlur, which includes more performance optimizations and bug fixes beyond ContextShadow. Cairo ports should also make this change.

Comment 1 Dirk Schulze 2011-07-18 13:11:39 PDT

*** Bug 53414 has been marked as a duplicate of this bug. ***

Comment 2 Martin Robinson 2011-07-22 11:56:50 PDT

Created attachment 101751 [details]
Patch

Comment 3 Dirk Schulze 2011-07-22 12:47:52 PDT

Comment on attachment 101751 [details]
Patch

Patch looks great in general, but can't get applied.

Comment 4 Martin Robinson 2011-07-22 13:34:15 PDT

Created attachment 101759 [details]
Patch rebased to master and with a aliasing fix

Comment 5 Gyuyoung Kim 2011-07-22 13:41:46 PDT

Comment on attachment 101759 [details]
Patch rebased to master and with a aliasing fix

Attachment 101759 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9234138

Comment 6 WebKit Review Bot 2011-07-22 13:48:18 PDT

Comment on attachment 101759 [details]
Patch rebased to master and with a aliasing fix

Attachment 101759 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9231193

Comment 7 Gustavo Noronha (kov) 2011-07-22 14:04:54 PDT

Comment on attachment 101759 [details]
Patch rebased to master and with a aliasing fix

Attachment 101759 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9234142

Comment 8 Martin Robinson 2011-07-22 14:12:06 PDT

Created attachment 101764 [details]
Patch fixing EFL build

Comment 9 WebKit Review Bot 2011-07-22 14:26:04 PDT

Comment on attachment 101764 [details]
Patch fixing EFL build

Attachment 101764 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9227247

Comment 10 Gyuyoung Kim 2011-07-22 14:43:16 PDT

Comment on attachment 101764 [details]
Patch fixing EFL build

Attachment 101764 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9230211

Comment 11 Martin Robinson 2011-07-22 14:52:42 PDT

Created attachment 101768 [details]
Fix GTK+ and EFL build

Comment 12 Dirk Schulze 2011-07-22 22:26:30 PDT

Comment on attachment 101768 [details]
Fix GTK+ and EFL build

LGTM. r=me

Comment 13 Martin Robinson 2011-07-28 01:13:38 PDT

Committed r91914: <http://trac.webkit.org/changeset/91914>

Comment 14 Daniel Bates 2011-07-30 23:50:24 PDT

(In reply to comment #13)
> Committed r91914: <http://trac.webkit.org/changeset/91914>

This change broke the WinCairo Debug build:
<http://build.webkit.org/builders/WinCairo%20Debug%20%28Build%29/builds/9282/steps/compile-webkit/logs/stdio>

Committed build fix in changeset 92074 <http://trac.webkit.org/changeset/92074>.