Bug 6468

Summary:

Remove CFDictionary from KWQObject.*

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
proposed patch.	darin: review+

Eric Seidel (no email)

Reported 2006-01-10 05:29:03 PST

Remove CFDictionary from KWQObject.* Attached patch does just that.

Attachments
proposed patch. (5.89 KB, patch) 2006-01-10 05:29 PST, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2006-01-10 05:29:27 PST

Created attachment 5597 [details] proposed patch.

Darin Adler

Comment 2 2006-01-10 07:05:11 PST

Comment on attachment 5597 [details] proposed patch. It seems strange to have a takeRunLoopTimer function in KWQObjectTimer since all of KWQObjectTimer's fields are public. If we're going to have a function to set a data member, then I think this should be a class with private data members. But if we're going to be a struct with public data members then it seems we should just use assignment instead of an inline function that does the assignment. Otherwise, looks great. r=me

Note You need to log in before you can comment on or make changes to this bug.