Summary: | [Gtk] [NRWT] Xvfb produces a lot of stderr output | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | pnormand, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Zan Dobersek
2011-07-17 06:30:17 PDT
Created attachment 101116 [details]
Redirect Xvfb stderr output to a subprocess PIPE
Comment on attachment 101116 [details] Redirect Xvfb stderr output to a subprocess PIPE View in context: https://bugs.webkit.org/attachment.cgi?id=101116&action=review > Tools/Scripts/webkitpy/layout_tests/port/gtk.py:46 > + self._xvfb_process = subprocess.Popen(run_xvfb, stderr=subprocess.PIPE) http://stackoverflow.com/questions/699325/suppress-output-in-python-calls-to-executables recommends to open /dev/null instead. Quoting the interesting comment: """ If your search engine lead you to this old question (like me), be aware that Manuel's solution (at this time the most valued), namely using PIPE can lead to deadlocks. Indeed, because pipes are buffered, you can write a certain number of bytes in a pipe, even if no one read it. However the size of buffer is finite. And consequently if your program A has an output larger than the buffer, A will be blocked on writing, while the calling program B awaits the termination of A. """ So the preferred solution would be something like: devnull = open(os.devnull, 'w') self._xvfb_process = subprocess.Popen(run_xvfb, stderr=devnull) devnull.close() Can you please check this would work? Thanks! (In reply to comment #2) > > devnull = open(os.devnull, 'w') > self._xvfb_process = subprocess.Popen(run_xvfb, stderr=devnull) > devnull.close() > > Can you please check this would work? > Thanks! This works just as fine, will upload a patch in a moment. Thanks for the review! Created attachment 101476 [details]
Redirect Xvfb stderr output to /dev/null
Comment on attachment 101476 [details]
Redirect Xvfb stderr output to /dev/null
Thanks :)
Comment on attachment 101476 [details] Redirect Xvfb stderr output to /dev/null Clearing flags on attachment: 101476 Committed r91374: <http://trac.webkit.org/changeset/91374> All reviewed patches have been landed. Closing bug. Very nice! |