Summary: | REGRESSION: Microphone icon in speech input field should be on the left for rtl | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Moskovich <playmobil> | ||||||||||
Component: | WebCore Misc. | Assignee: | Jeremy Moskovich <playmobil> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, eric, leviw, mitz, morrita, rniwa, satish, tkent, webkit.review.bot | ||||||||||
Priority: | P1 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 64108 | ||||||||||||
Attachments: |
|
Description
Jeremy Moskovich
2011-07-17 04:51:40 PDT
Created attachment 101115 [details]
Patch
Comment on attachment 101115 [details] Patch Attachment 101115 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9097978 New failing tests: fast/speech/speech-bidi-rendering.html fast/speech/input-text-speechbutton.html Comment on attachment 101115 [details]
Patch
This looks like a great fix! Needs a bit of test-expectation-lovin' though.
Comment on attachment 101115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101115&action=review > LayoutTests/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). Reviewed by should appear before the long description. > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). Ditto. Not sure why this patch was r-ed. It seems like this patch is ready to be committed manually. Comment on attachment 101115 [details]
Patch
sure.
Comment on attachment 101115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101115&action=review > Source/WebCore/css/html.css:479 > +input[x-webkit-speech][dir=rtl]::-webkit-textfield-decoration-container { > + direction: rtl; > +} I don't think this works well with * <span dir=rtl><input x-webkit-speech></span> or * <input x-webkit-speech style="direction:rtl"> Created attachment 101132 [details]
Patch
tkent: Thanks for catching those cases! I guess we'll need to propagate manually when we do style recalc. Is there already a framework for doing this? Are any other styles handled this way? Or should I just dig around? All regressions are P1. Comment on attachment 101132 [details] Patch Rejecting attachment 101132 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: l patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3826. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej patching file LayoutTests/platform/mac/fast/speech/speech-bidi-rendering-expected.txt patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/css/html.css Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9114395 Created attachment 101298 [details]
Patch for landing
Comment on attachment 101298 [details] Patch for landing Rejecting attachment 101298 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 1 Last 500 characters of output: 2d18fb44881a8dd2b965b115eb940129d9229d6a r91248 = cc2dc4e12e4b1be22f4884548c02c0596956beb2 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9153132 Created attachment 101303 [details]
Patch for landing
Comment on attachment 101303 [details] Patch for landing Clearing flags on attachment: 101303 Committed r91249: <http://trac.webkit.org/changeset/91249> All reviewed patches have been landed. Closing bug. |