Bug 64586

Summary: NRWT stores the Chromium revision number in full_results.json
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch eric: review+, abarth: commit-queue?

Description Adam Barth 2011-07-15 00:39:51 PDT
http://test-results.appspot.com/testfile?builder=Webkit%20Linux%20(dbg)(1)&name=full_results.json

"revision":"92662"

=====
[chrome]	Repository:  

Index of /

Files shown:	2
Directory revision:	92662 (of 92662)
Sticky Revision:	   
=====

Whereas, in WebKit:

07/15/2011: Today
00:23 Changeset [91057] by commit-queue@webkit.org

I don't really understand how that's possible:

http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py#L212
Comment 1 Eric Seidel (no email) 2011-07-15 00:42:56 PDT
I'm confused what this bug is saying.

It's very possible our svn info parsing is broken.  Can you show me an example full_results.json with invalid values?
Comment 3 Adam Barth 2011-07-15 01:19:46 PDT
Created attachment 100946 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-07-15 01:20:49 PDT
Comment on attachment 100946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100946&action=review

OK.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:612
> +        # FIXME: Due to Chromium's insane DEPS system, the root of the WebKit

Well the DEPS system isn't insane, just their setup.
Comment 5 Adam Barth 2011-07-15 01:22:46 PDT
Committed r91059: <http://trac.webkit.org/changeset/91059>