Summary: | DFG JIT is inconsistent about fusing branches and speculating integer comparisons for branches | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | barraclough, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Filip Pizlo
2011-07-14 16:40:58 PDT
Created attachment 100902 [details]
the patch
Attachment 100902 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/dfg/DFGOperations.cpp:424: Should have a space between // and comment [whitespace/comments] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:425: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 100908 [details]
the patch (fix style)
Comment on attachment 100908 [details]
the patch (fix style)
static_cast<int32_t>(1) seems a little odd... I guess this is just code that's moving (I guess we could also just return a JSValue / intptr_t from these helper operations, save the extra instruction). No need for these ideas to be incorporated into this patch though.
Comment on attachment 100908 [details] the patch (fix style) Rejecting attachment 100908 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: 2 FAILED at 534. 1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h.rej patching file Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.cpp patching file Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.h patching file Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp patching file Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Gavin Barraclough', u'..." exit_code: 1 Full output: http://queues.webkit.org/results/9093107 (In reply to comment #4) > (From update of attachment 100908 [details]) > static_cast<int32_t>(1) seems a little odd... I guess this is just code that's moving (I guess we could also just return a JSValue / intptr_t from these helper operations, save the extra instruction). No need for these ideas to be incorporated into this patch though. Yeah, that looks like a wart. I'l go ahead and fix it, since it appears that this patch failed to land. Created attachment 100941 [details]
the patch (fix conflict, fix review)
Fixes a conflict with one of my other patches. This patch should be able to land successfully. Also removes the superfluous static_cast.
Created attachment 100942 [details]
the patch (fix Platform.h)
Oops - the last patch included a change to Platform.h that shouldn't have gotten into the patch.
Comment on attachment 100942 [details] the patch (fix Platform.h) Clearing flags on attachment: 100942 Committed r91099: <http://trac.webkit.org/changeset/91099> All reviewed patches have been landed. Closing bug. |