| Summary: | Store error and warning information on TestExpectationLine. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, ap, elmaasheley147 | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 64559 | ||||||
| Bug Blocks: | 64385 | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2011-07-14 15:22:56 PDT
Created attachment 100874 [details]
Patch
Comment on attachment 100874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100874&action=review This looks good. > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 > # FIXME: Shouldn't return anything, this is a temporary layering volation. Presumably this FIXME is now fixed. > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:644 > + lineno += 1 I think there's a way to iterate over a list that will give you the list index during the iteration. Comment on attachment 100874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100874&action=review >> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:644 >> + lineno += 1 > > I think there's a way to iterate over a list that will give you the list index during the iteration. enumerate!!! Holy Crap!!! I <3 Python. Comment on attachment 100874 [details] Patch Clearing flags on attachment: 100874 Committed r91073: <http://trac.webkit.org/changeset/91073> All reviewed patches have been landed. Closing bug. |