Bug 64565

Summary: Store error and warning information on TestExpectationLine.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, elmaasheley147
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64559    
Bug Blocks: 64385    
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2011-07-14 15:22:56 PDT
Store error and warning information on TestExpectationLine.
Attachments
Patch (21.86 KB, patch)
2011-07-14 15:29 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-14 15:29:00 PDT
Created attachment 100874 [details] Patch
Adam Barth
Comment 2 2011-07-14 22:52:39 PDT
Comment on attachment 100874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100874&action=review This looks good. > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:316 > # FIXME: Shouldn't return anything, this is a temporary layering volation. Presumably this FIXME is now fixed. > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:644 > + lineno += 1 I think there's a way to iterate over a list that will give you the list index during the iteration.
Dimitri Glazkov (Google)
Comment 3 2011-07-15 08:56:21 PDT
Comment on attachment 100874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100874&action=review >> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:644 >> + lineno += 1 > > I think there's a way to iterate over a list that will give you the list index during the iteration. enumerate!!! Holy Crap!!! I <3 Python.
Dimitri Glazkov (Google)
Comment 4 2011-07-15 08:58:06 PDT
Comment on attachment 100874 [details] Patch Clearing flags on attachment: 100874 Committed r91073: <http://trac.webkit.org/changeset/91073>
Dimitri Glazkov (Google)
Comment 5 2011-07-15 08:58:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.