Bug 64538 – TiledDrawingArea: map the visibleArea rect from page to scaled coordinates.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jocelyn Turcotte]

TiledDrawingArea: map the visibleArea rect from page to scaled coordinates.

[Jocelyn Turcotte]

Created attachment 100827 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 100827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100827&action=review

> Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:170
> +    WebCore::IntRect m_contentsVisibleArea;

visibleContentRect is used for this elsewhere, like in FrameView.. maybe we should use the same terminology?

[Benjamin Poulain]

Comment on attachment 100827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100827&action=review

> Source/WebKit2/ChangeLog:8
> +        TiledDrawingAreaProxy expects it's coordinates to be scaled according to

it's -> its

[Benjamin Poulain]

(In reply to comment #2)
> visibleContentRect is used for this elsewhere, like in FrameView.. maybe we should use the same terminology?

+1 :)

[Benjamin Poulain]

I see I introduced the regression here: http://trac.webkit.org/changeset/90750
Maybe mention you fix a regression introduced by r90750 in the Changelog?

[Jocelyn Turcotte]

Created attachment 101003 [details]
Patch

Resubmitting for review after renaming all visibleAreas.
Please tell also what you think: visibleContentsRect or visibleContentRect? From what I saw contents is right, but that's not how it's written elsewhere.

[Kenneth Rohde Christiansen]

WebCore uses visibleContentRect

[Kenneth Rohde Christiansen]

http://www.english-test.net/forum/ftopic12826.html#36416 <- content vs contents :-)

[Jocelyn Turcotte]

(In reply to comment #6)
> Created an attachment (id=101003) [details]
> Patch
> 
> Resubmitting for review after renaming all visibleAreas.
> Please tell also what you think: visibleContentsRect or visibleContentRect? From what I saw contents is right, but that's not how it's written elsewhere.

Humm forgot the changelog note for the regression, will update before pushing in any case.

[Benjamin Poulain]

Comment on attachment 101003 [details]
Patch

Looks good. Sorry about the regression, I totally missed in which coordinate the view is, for some reason I assumed those coordinates were scaled.

[Jocelyn Turcotte]

Committed r91180: <http://trac.webkit.org/changeset/91180>