| Summary: | MediaStream API: Release script objects when detaching document | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Henrik Grunell <grunell> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | donggwan.kim, tommyw, tonyg, wjjeon | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 56459 | ||||||
| Attachments: |
|
||||||
|
Description
Henrik Grunell
2011-07-14 05:54:40 PDT
Created attachment 100945 [details]
Patch
Comment on attachment 100945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100945&action=review r- for lack of test > Source/WebCore/ChangeLog:10 > + No new tests because the patch is just a bug fix. In WebKit, fixing a bug is usually a great reason to add a test. This is the sort of edge case that could easily break during future refactoring, so please add a test so we don't regress here. > Source/WebCore/dom/Document.cpp:1778 > + if (mediaStreamFrameController) If you prefer, a common idiom in WebKit is: if (MediaStreamFrameController* mediaStreamFrameController = m_frame->mediaStreamFrameController()) mediaStreamFrameController->clearAllClients(); Comment on attachment 100945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100945&action=review >> Source/WebCore/ChangeLog:10 >> + No new tests because the patch is just a bug fix. > > In WebKit, fixing a bug is usually a great reason to add a test. This is the sort of edge case that could easily break during future refactoring, so please add a test so we don't regress here. Check out LayoutTests/fast/dom/Geolocation/page-reload-cancel-permission-requests.html for a possible way to do a test involving a reload. |