Bug 64495

Summary: gardening server should have an API for parsing changelogs
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64183    
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-07-13 17:48:56 PDT
gardening server should have an API for parsing changelogs
Attachments
Patch (14.90 KB, patch)
2011-07-13 17:51 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (15.14 KB, patch)
2011-07-13 18:10 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-07-13 17:51:00 PDT
Created attachment 100741 [details] Patch
Eric Seidel (no email)
Comment 2 2011-07-13 17:52:42 PDT
Comment on attachment 100741 [details] Patch I wonder why you wouldn't want to add a to_json() method to CommitInfo instead.
Adam Barth
Comment 3 2011-07-13 18:10:50 PDT
Created attachment 100745 [details] Patch
Eric Seidel (no email)
Comment 4 2011-07-13 18:17:51 PDT
Comment on attachment 100745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100745&action=review Seems OK. > Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:61 > + head_revision = self.server.tool.scm().head_svn_revision() > + if revision > head_revision: Seems like we want some sort of "includes_revision()" check somewhere here. Either on this class, or preferably on SCM itself. This is OK, but such code sharing might be better.
Adam Barth
Comment 5 2011-07-13 18:19:59 PDT
Comment on attachment 100745 [details] Patch I'm not going to worry about the includes_revision thing now. These are easy to find later by grepping for head_svn_revision.
Adam Barth
Comment 6 2011-07-13 18:39:16 PDT
Comment on attachment 100745 [details] Patch Clearing flags on attachment: 100745 Committed r90968: <http://trac.webkit.org/changeset/90968>
Adam Barth
Comment 7 2011-07-13 18:39:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.