Bug 64495

Summary:

gardening server should have an API for parsing changelogs

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

64183

Attachments:

Description	Flags
Patch	none
Patch	none

Description Adam Barth 2011-07-13 17:48:56 PDT

gardening server should have an API for parsing changelogs

Comment 1 Adam Barth 2011-07-13 17:51:00 PDT

Created attachment 100741 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-07-13 17:52:42 PDT

Comment on attachment 100741 [details]
Patch

I wonder why you wouldn't want to add a to_json() method to CommitInfo instead.

Comment 3 Adam Barth 2011-07-13 18:10:50 PDT

Created attachment 100745 [details]
Patch

Comment 4 Eric Seidel (no email) 2011-07-13 18:17:51 PDT

Comment on attachment 100745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100745&action=review

Seems OK.

> Tools/Scripts/webkitpy/tool/servers/gardeningserver.py:61
> +        head_revision = self.server.tool.scm().head_svn_revision()
> +        if revision > head_revision:

Seems like we want some sort of "includes_revision()" check somewhere here.  Either on this class, or preferably on SCM itself. This is OK, but such code sharing might be better.

Comment 5 Adam Barth 2011-07-13 18:19:59 PDT

Comment on attachment 100745 [details]
Patch

I'm not going to worry about the includes_revision thing now.  These are easy to find later by grepping for head_svn_revision.

Comment 6 Adam Barth 2011-07-13 18:39:16 PDT

Comment on attachment 100745 [details]
Patch

Clearing flags on attachment: 100745

Committed r90968: <http://trac.webkit.org/changeset/90968>

Comment 7 Adam Barth 2011-07-13 18:39:20 PDT

All reviewed patches have been landed.  Closing bug.