| Summary: | Implement WKPageCenterSelectionInVisibleArea | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||
| Component: | WebKit2 | Assignee: | Ada Chan <adachan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | jeffm, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Ada Chan
2011-07-13 13:45:05 PDT
Created attachment 100712 [details]
Patch
Comment on attachment 100712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > Source/WebKit2/ChangeLog:9 > + (WKPageCenterSelectionInVisibleArea): You should add a description here, even it it's just to note that this function was added. (In reply to comment #2) > (From update of attachment 100712 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > > > Source/WebKit2/ChangeLog:9 > > + (WKPageCenterSelectionInVisibleArea): > > You should add a description here, even it it's just to note that this function was added. OK, added this comment: (WKPageCenterSelectionInVisibleArea): Added. Call WebPageProxy::centerSelectionInVisibleArea(). Comment on attachment 100712 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1244 > + if (!frameSelection) > + return; Frame::selection can never return null, so you can just call coreFrame->selection()->revealSelection directly. (In reply to comment #4) > (From update of attachment 100712 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1244 > > + if (!frameSelection) > > + return; > > Frame::selection can never return null, so you can just call coreFrame->selection()->revealSelection directly. OK, will do. Thanks! |