Bug 64481 – Implement WKPageCenterSelectionInVisibleArea

• Component: WebKit2
• Status: RESOLVED FIXED

[Ada Chan]

This is the WebKit2 counterpart of WebView::centerSelectionInVisibleArea() in WebKit1.

Related to <rdar://problem/9732174>

[Ada Chan]

Created attachment 100712 [details]
Patch

[Jeff Miller]

Comment on attachment 100712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review

> Source/WebKit2/ChangeLog:9
> +        (WKPageCenterSelectionInVisibleArea):

You should add a description here, even it it's just to note that this function was added.

[Ada Chan]

(In reply to comment #2)
> (From update of attachment 100712 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        (WKPageCenterSelectionInVisibleArea):
> 
> You should add a description here, even it it's just to note that this function was added.

OK, added this comment:
        (WKPageCenterSelectionInVisibleArea): Added.  Call WebPageProxy::centerSelectionInVisibleArea().

[Anders Carlsson]

Comment on attachment 100712 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1244
> +    if (!frameSelection)
> +        return;

Frame::selection can never return null, so you can just call coreFrame->selection()->revealSelection directly.

[Ada Chan]

(In reply to comment #4)
> (From update of attachment 100712 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100712&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1244
> > +    if (!frameSelection)
> > +        return;
> 
> Frame::selection can never return null, so you can just call coreFrame->selection()->revealSelection directly.

OK, will do.  Thanks!

[Ada Chan]

Fixed in http://trac.webkit.org/changeset/91012