Bug 64455

Summary:

TestFailures page doesn't show as much information for flaky tests as I would like, even though the page is already so long

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dbates, ddkilzer, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adam Roben (:aroben) 2011-07-13 08:26:05 PDT

TestFailures page doesn't show as much information for flaky tests as I would like, even though the page is already so long

Comment 1 Adam Roben (:aroben) 2011-07-13 08:27:08 PDT

Created attachment 100676 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2011-07-13 08:38:10 PDT

Comment on attachment 100676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100676&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:427
> +            var disclosureTriangle = document.createElement('span');
> +            item.appendChild(disclosureTriangle);
> +
> +            disclosureTriangle.className = 'disclosure-triangle';
> +            const blackRightPointingSmallTriangle = '\u25b8';
> +            disclosureTriangle.appendChild(document.createTextNode(blackRightPointingSmallTriangle));

you should totally try using details/summary here. If it doesn't work, we should fix bugs :)

Comment 3 WebKit Review Bot 2011-07-13 09:30:36 PDT

Comment on attachment 100676 [details]
Patch

Clearing flags on attachment: 100676

Committed r90922: <http://trac.webkit.org/changeset/90922>

Comment 4 WebKit Review Bot 2011-07-13 09:30:40 PDT

All reviewed patches have been landed.  Closing bug.