Bug 64420

Summary: [chromium] No implementation defined for WTF::monotonicallyIncreasingTime
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, nduca, simonjam, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tonyg: review+, webkit.review.bot: commit-queue-

James Robinson
Reported 2011-07-12 18:55:48 PDT
[chromium] No implementation defined for WTF::monotonicallyIncreasingTime
Attachments
Patch (4.64 KB, patch)
2011-07-12 18:57 PDT, James Robinson 		tonyg: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-07-12 18:57:07 PDT
Created attachment 100605 [details] Patch
James Robinson
Comment 2 2011-07-12 18:58:07 PDT
It looks like the old code was trying to define WebCore::monotonicallyIncreasingTime() in SystemTimeChromium.cpp, but that won't work since it's a WTF function not WebCore. That's partially my fault (looks like I reviewed that patch).
WebKit Review Bot
Comment 3 2011-07-13 12:11:53 PDT
Comment on attachment 100605 [details] Patch Rejecting attachment 100605 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1 Last 500 characters of output: 68340cff4e2d9fe7af5c87bc85729b84b60ecae3 r90938 = 4710a59a2cdebe8c4b631e948d381490d2b296d8 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9017647
James Robinson
Comment 4 2011-07-13 14:46:29 PDT
Whoops, I accidentally the 'Reviewed by ..' line.
James Robinson
Comment 5 2011-07-13 14:51:26 PDT
Committed r90952: <http://trac.webkit.org/changeset/90952>
Note You need to log in before you can comment on or make changes to this bug.