| Summary: | sheriffbot isn't reopening patches after it lands rollouts | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||||
| Component: | New Bugs | Assignee: | Tom Zakrajsek <tomz> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dpranke, eric, ojan, tomz | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
WebKit Review Bot
2011-07-12 18:20:29 PDT
This is worth fixing if it's still the case. Do you mean re-open the bug? Is this something that webkit-patch create-rollout should do? I'm having trouble understanding the different use-cases for prepare-rollout, create-rollout, and rollout in webkit-patch. > prepare-rollout This is meant to be a local command that only affects the local working copy. We could rename this to prepare-rollout-locally if that would be clearer. > create-rollout This is meant to post a rollout patch to a new bug. We could rename this to "post-rollout" if that would be clearer. > rollout This is meant to actually do a full rollout, including preparing the local change and then landing it. > Is this something that webkit-patch create-rollout should do?
Sure. The only risk there is that we'll create a rollout patch but never land it. I guess that means the person will just have to close their bug again.
I think that's reasonable. Especially since the alternative is that there could be a bug out there with a patch waiting to undo an author's change that they might not be aware of. There's already logic to mark the rollout bug as blocking the original bug. It's probably easy to make it re-open the bug at that stage. Created attachment 111989 [details]
Patch
As I mentioned to tomz in IRC, we can test this either using a step unittest or a command unittest. In either case, the MockTool will be substituted for the tool and the reopen_bug function on the mock object should generate logging output that we can capture and check. Created attachment 140418 [details]
Patch
Comment on attachment 140418 [details]
Patch
Ah, nice approach.
Comment on attachment 140418 [details] Patch Clearing flags on attachment: 140418 Committed r116245: <http://trac.webkit.org/changeset/116245> All reviewed patches have been landed. Closing bug. I'm not sure I follow exactly. This makes it so that when sherriff-bot creates a rollout he re-opens the original bug? (In reply to comment #13) > I'm not sure I follow exactly. This makes it so that when sherriff-bot creates a rollout he re-opens the original bug? Yes. |