| Summary: | ApplicationCache Quota Output is Flakey | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
| Component: | Tools / Tests | Assignee: | Joseph Pecoraro <joepeck> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, cshu, joepeck, laszlo.gombos, robert | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Joseph Pecoraro
2011-07-12 16:48:45 PDT
Skipped the tests temporarily in: http://trac.webkit.org/changeset/90870 I didn't think printing out the exact number of bytes was safe, but I thought the same code was shared in WebCore. First, I need to fix the printf format in DumpRenderTreeQt, then I should make printing the number of bytes more robust. Adding some Qt developers involved in adding ApplicationCache Quotas for Qt. Now, back to the drawing board. Created attachment 100598 [details]
[PATCH] Starting Point
For starters, I put the newline in the wrong spot and then replaced it with a space.
This patch puts the newline in the right spot. But that still doesn't handle the
# of bytes being different, which is probably brittle to begin with. I'm going
to investigate that a bit more.
estimatedSizeInStorage includes some HTTP response data, which of course could vary with each request and across platforms. I can't include the # directly. Skipped on platform/mac as well. <http://trac.webkit.org/changeset/90883> I had missed one test on run-webkit-tests after a rename as well. I'd still like some value in these tests. Maybe approximating to 10000 bytes would work? Instead of 31003*bytes something "like ~30000 bytes" would work. Or just not printing any number... Created attachment 100623 [details]
[PATCH] Truncate space needed to ten thousands
Comment on attachment 100623 [details] [PATCH] Truncate space needed to ten thousands View in context: https://bugs.webkit.org/attachment.cgi?id=100623&action=review bdash pointed out a grammar mistake. > Tools/DumpRenderTree/mac/UIDelegate.mm:173 > + // Rounding up or down down not really matter for these tests. Its I will fix this "up or down down" => "up or down" when landing. > Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:1046 > + // Rounding up or down down not really matter for these tests. Its I will fix this "up or down down" => "up or down" when landing. Landed in <http://trac.webkit.org/changeset/90946>. Watching the bots. Caught this early: <http://trac.webkit.org/changeset/90951> That "\n" is going to be the end of me. I've already moved it, removed it, and now forgotten to add it. Sorry about all of the churn related to this. This now looks good on Qt and Mac. Yay! |