Bug 64407

Summary:

garden-o-matic should display regression ranges

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Adam Barth 2011-07-12 16:16:31 PDT

garden-o-matic should display regression ranges

Comment 1 Adam Barth 2011-07-12 16:18:22 PDT

Created attachment 100581 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2011-07-12 16:26:17 PDT

Comment on attachment 100581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100581&action=review

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:47
> +    return keys;

Could use Object.keys if available :)

Comment 3 Adam Barth 2011-07-12 16:29:29 PDT

Created attachment 100584 [details]
Patch

Comment 4 Adam Barth 2011-07-12 16:30:28 PDT

> Could use Object.keys if available :)

Yeah, I'm not sure which browser's we targeting.  :(

Comment 5 Adam Barth 2011-07-12 16:31:09 PDT

Committed r90866: <http://trac.webkit.org/changeset/90866>