Bug 64377

Summary: [WinCairo] Standardize on PLATFORM(WIN_CAIRO) definitions
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Brent Fulgham
Reported 2011-07-12 11:43:57 PDT
The current source tree conditionalizes various WinCairo features using "#ifdef WIN_CAIRO". This is inconsistent with all other ports, which properly define WTF_PLATFORM_xxx, and use the corresponding PLATFORM(xxx) to test for this state. This bug: 1. Changes WIN_CAIRO to WTF_PLATFORM_WIN_CAIRO 2. Changes instanced of "#ifdef WIN_CAIRO" or "#ifndef WIN_CAIRO" to "#if PLATFORM(WIN_CAIRO)" or "#if !PLATFORM(WIN_CAIRO)". It also removes a redundant definition of WIN_CAIRO in a project file, which should properly be controlled by the vsprops files.
Attachments
Patch (6.68 KB, patch)
2011-07-12 13:26 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (10.00 KB, patch)
2011-07-12 14:00 PDT, Brent Fulgham 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2011-07-12 13:26:06 PDT
Created attachment 100551 [details] Patch
Brent Fulgham
Comment 2 2011-07-12 14:00:10 PDT
Created attachment 100556 [details] Patch
Adam Roben (:aroben)
Comment 3 2011-07-12 14:02:35 PDT
Maciej, you should take a look at this.
Maciej Stachowiak
Comment 4 2011-07-12 20:12:04 PDT
Comment on attachment 100556 [details] Patch r=me
Brent Fulgham
Comment 5 2011-07-13 12:32:38 PDT
Committed r90940: <http://trac.webkit.org/changeset/90940>
Note You need to log in before you can comment on or make changes to this bug.