Bug 64365

Summary:

TiledDrawingArea: Handle update requests in the order they were received.

Product:

WebKit

Reporter:

Jocelyn Turcotte <jturcotte>

Component:

New Bugs

Assignee:

Jocelyn Turcotte <jturcotte>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	kling: review+

Description Jocelyn Turcotte 2011-07-12 09:22:59 PDT

TiledDrawingArea: Handle update requests in the order they were received.

Comment 1 Jocelyn Turcotte 2011-07-12 09:25:29 PDT

Created attachment 100497 [details]
Patch

Comment 2 Andreas Kling 2011-07-26 11:09:19 PDT

Comment on attachment 100497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100497&action=review

Looks good, but let's clean it up a bit.

> Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:181
> +    for (UpdateList::iterator it = m_pendingUpdates.begin(); it != m_pendingUpdates.end(); ++it) {

Keep the end() iterator in a separate variable for micro-optimization goodness.

> Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:196
> +    for (UpdateList::iterator it = m_pendingUpdates.begin(); it != m_pendingUpdates.end(); ++it) {

Ditto.

> Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:200
> +            found = true;
> +            break;

Simply return; here, and you won't even need the "found" variable.

Comment 3 Jocelyn Turcotte 2011-07-29 08:53:57 PDT

Created attachment 102369 [details]
Patch

Suggestions proudly fulfilled.

Comment 4 Andreas Kling 2011-08-01 00:14:41 PDT

Comment on attachment 102369 [details]
Patch

r=me!

Comment 5 Jocelyn Turcotte 2011-08-02 10:01:37 PDT

Committed r92198: <http://trac.webkit.org/changeset/92198>