Bug 64365

Summary: TiledDrawingArea: Handle update requests in the order they were received.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Jocelyn Turcotte
Reported 2011-07-12 09:22:59 PDT
TiledDrawingArea: Handle update requests in the order they were received.
Attachments
Patch (4.72 KB, patch)
2011-07-12 09:25 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (4.70 KB, patch)
2011-07-29 08:53 PDT, Jocelyn Turcotte 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-07-12 09:25:29 PDT
Created attachment 100497 [details] Patch
Andreas Kling
Comment 2 2011-07-26 11:09:19 PDT
Comment on attachment 100497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100497&action=review Looks good, but let's clean it up a bit. > Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:181 > + for (UpdateList::iterator it = m_pendingUpdates.begin(); it != m_pendingUpdates.end(); ++it) { Keep the end() iterator in a separate variable for micro-optimization goodness. > Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:196 > + for (UpdateList::iterator it = m_pendingUpdates.begin(); it != m_pendingUpdates.end(); ++it) { Ditto. > Source/WebKit2/WebProcess/WebPage/TiledDrawingArea.cpp:200 > + found = true; > + break; Simply return; here, and you won't even need the "found" variable.
Jocelyn Turcotte
Comment 3 2011-07-29 08:53:57 PDT
Created attachment 102369 [details] Patch Suggestions proudly fulfilled.
Andreas Kling
Comment 4 2011-08-01 00:14:41 PDT
Comment on attachment 102369 [details] Patch r=me!
Jocelyn Turcotte
Comment 5 2011-08-02 10:01:37 PDT
Committed r92198: <http://trac.webkit.org/changeset/92198>
Note You need to log in before you can comment on or make changes to this bug.