Bug 64359

Summary:

Missing right padding on inline element

Product:

WebKit

Reporter:

Martin Major <ngsoftware>

Component:

CSS

Assignee:

Fred Liu <fredliu>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

bfulgham, fredliu, mitz, shanestephens, simon.fraser, webkit.review.bot, zalan

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://jsbin.com/irokew/

Attachments:

Description	Flags
Testing page	none
Proposed patch	none
Proposed patch version 2	hyatt: review-, hyatt: commit-queue-

Martin Major

Reported 2011-07-12 07:30:15 PDT

Created attachment 100482 [details] Testing page Look at testing page at: http://jsbin.com/irokew/ Behavior in Chrome, Safari, Android: Last tab has no right padding. Behavior in Firefox, Opera, IE: Last tab has 10px right padding. This bug depends on spaces. When you delete space between ending </a> and </li> example page will be rendered correctly: http://jsbin.com/irokew/2/

Attachments
Testing page (390 bytes, text/html) 2011-07-12 07:30 PDT, Martin Major	no flags	Details
Proposed patch (5.41 KB, patch) 2011-08-19 11:47 PDT, Fred Liu	no flags	Details Formatted Diff Diff
Proposed patch version 2 (6.30 KB, patch) 2011-08-19 12:13 PDT, Fred Liu	hyatt: review- hyatt: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Fred Liu

Comment 1 2011-08-19 11:47:15 PDT

Created attachment 104539 [details] Proposed patch

WebKit Review Bot

Comment 2 2011-08-19 11:49:43 PDT

Attachment 104539 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] Total errors found: 9 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Fred Liu

Comment 3 2011-08-19 12:13:03 PDT

Created attachment 104543 [details] Proposed patch version 2

Dave Hyatt

Comment 4 2011-08-19 13:54:22 PDT

Comment on attachment 104543 [details] Proposed patch version 2 This is not right. You're patching the wrong place. It looks like the maximum preferred intrinsic width is being computed incorrectly and is too small. That's what you need to fix, not the line breaking code.

Fred Liu

Comment 5 2011-08-19 14:01:06 PDT

Thanks. I'll look into the code calculating the maximum preferred intrinsic width.

Dave Hyatt

Comment 6 2011-08-22 14:08:18 PDT

Comment on attachment 104543 [details] Proposed patch version 2 Oops, I was wrong about this. I got faked out by the margins on the test case. Yeah it does look like the max preferred width is correct but the padding simply isn't rendering.

Martin Major

Comment 7 2014-02-05 02:46:32 PST

Is there any progress with this issue?

Brent Fulgham

Comment 8 2022-07-12 14:56:43 PDT

Safari, Chrome, and Firefox all agree on rendering for this test case. I don't believe there is any remaining compatibility issue.

zalan

Comment 9 2022-07-12 15:08:36 PDT

This is an IFC progression (when IFC is disabled, WebKit renders the testing page incorrectly)

Note You need to log in before you can comment on or make changes to this bug.