Bug 64356 – Web Inspector: InspectorResourceAgent should generate unique identifier and save cachedResource for resources from memory cache.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Vsevolod Vlasov]

InspectorResourceAgent should generate unique identifier and save cachedResource for resources from memory cache.

[Vsevolod Vlasov]

Created attachment 100703 [details]
Patch

[Pavel Feldman]

Comment on attachment 100703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100703&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:760
> +                    originalResource.networkDataRemoved = true;

I don't like the fact that resource is marked as "data removed" independently on the front-end. It should be either explicit "data collected" event or we should simply return error upon backend requests in such cases. We are missing unique identifiers across processes to implement this though.

[Yury Semikhatsky]

Comment on attachment 100703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100703&action=review

> Source/WebCore/inspector/InspectorInstrumentation.h:-121
> -    static void didLoadResourceFromMemoryCache(Page*, DocumentLoader*, const CachedResource*);

Can we make ResourceData keep const CachedResource* instead? Inspector code shouldn't modify cached resources.

[Yury Semikhatsky]

Comment on attachment 100703 [details]
Patch

Ok, I see now that the problem is in CachedResource::makePurgable call which we should be able to avoid in inspector code but it deserve its own change.

[WebKit Review Bot]

Comment on attachment 100703 [details]
Patch

Clearing flags on attachment: 100703

Committed r91006: <http://trac.webkit.org/changeset/91006>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.