Bug 64352

Summary: [Qt] REGRESSION(r90634): It made http/tests/misc/script-async.html fail with Qt 4.8.x
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Critical CC: benjamin, kling, markus, ossy, peter.hartmann
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 64169    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogonác 2011-07-12 04:28:49 PDT 
--- /ramdisk/qt-linux-32-release-qt470/build/layout-test-results/http/tests/misc/script-async-expected.txt	2011-07-12 03:36:30.445722227 -0700
+++ /ramdisk/qt-linux-32-release-qt470/build/layout-test-results/http/tests/misc/script-async-actual.txt	2011-07-12 03:36:30.445722227 -0700
@@ -1,2 +1,2 @@
 This tests for proper execution order of scripts with the async attribute https://bugs.webkit.org/show_bug.cgi?id=20710.
-PASS
+FAIL: Expected one of ' async  external  inline  DOMContentLoaded  slowAsync ' || ' external  async  inline  DOMContentLoaded  slowAsync ' || ' external  inline  async  DOMContentLoaded  slowAsync ' || ' external  inline  DOMContentLoaded  async  slowAsync ', Actual=' external  inline  DOMContentLoaded  slowAsync  async '

Marked as P1 critical, because it is a regression.
Comment 1 Benjamin Poulain 2011-07-12 04:54:55 PDT 
Peter, Markus, would one of you have time to investigate why http pipelining break the tests?

I am tempted to just revert r90634 since this demonstrate Qt's Http pipelining is not ready for prime time.
Comment 2 Markus Goetz 2011-07-12 05:32:34 PDT 
@Benjamin: HTTP pipelining should not be enabled for Ajax stuff. Everything that blocks the socket (e.g. long polling, COMET, whatever) should not be pipelined.
Comment 3 Markus Goetz 2011-07-12 05:36:04 PDT 
@Benjamin: See for example bug 50644
Comment 4 Csaba Osztrogonác 2011-07-13 00:07:29 PDT 
I skip this test until you fix the bug: http://trac.webkit.org/changeset/90891
Comment 5 Benjamin Poulain 2011-07-13 05:08:35 PDT 
Created attachment 100659 [details]
Patch
Comment 6 Andreas Kling 2011-07-13 05:09:23 PDT 
Comment on attachment 100659 [details]
Patch

Arr plus.
Comment 7 Benjamin Poulain 2011-07-13 05:13:17 PDT 
Comment on attachment 100659 [details]
Patch

Clearing flags on attachment: 100659

Committed r90906: <http://trac.webkit.org/changeset/90906>
Comment 8 Benjamin Poulain 2011-07-13 05:13:24 PDT 
All reviewed patches have been landed.  Closing bug.