| Summary: | [skia] optimize getImageData to avoid a copy when not needed. lockPixels() now does the right thing. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Reed <reed> | ||||||||
| Component: | New Bugs | Assignee: | Mike Reed <reed> | ||||||||
| Status: | RESOLVED WONTFIX | ||||||||||
| Severity: | Normal | CC: | bsalomon, dglazkov, jamesr, kbr, schenney, senorblanco, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 64389 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Mike Reed
2011-07-11 11:54:54 PDT
Created attachment 100341 [details]
Patch
Comment on attachment 100341 [details] Patch Attachment 100341 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9014296 Comment on attachment 100341 [details]
Patch
Does this need a roll of the Chromium revision in WebKit/Source/WebKit/chromium/DEPS, and is that why the patch doesn't build on the cr-linux EWS?
Created attachment 100344 [details]
Patch
may need webkit to update to a newer chrome/skia DEPS for this to build. Comment on attachment 100344 [details] Patch Attachment 100344 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9010567 Comment on attachment 100344 [details]
Patch
Per above comment, please update chromium_rev in Source/WebKit/chromium/DEPS.
Created attachment 100470 [details]
Patch
no code change for this patch, just rebaselined the ChangeLog file Comment on attachment 100470 [details]
Patch
Looks good to me.
Comment on attachment 100470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100470&action=review > Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:228 > + return result.release(); Just for my own edification: is this early-out for failure of the accessBitmap(), the extractSubset() or both? accessBitmap() never fails. The boolean check is on extractSubset(). Comment on attachment 100470 [details]
Patch
Looks good to me too (restoring r+).
Comment on attachment 100470 [details] Patch Clearing flags on attachment: 100470 Committed r90831: <http://trac.webkit.org/changeset/90831> All reviewed patches have been landed. Closing bug. |