Bug 64296

Summary: WebSocket: Fix handshake format in pywebsocket handlers of hybi tests
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: Tools / TestsAssignee: Yuta Kitamura <yutak>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, ap, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 50099    
Attachments:
Description Flags
Patch none

Yuta Kitamura
Reported 2011-07-11 10:44:27 PDT
Fix part of tests under http/tests/websocket/tests/hybi.
Attachments
Patch (10.91 KB, patch)
2011-07-11 11:10 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-07-11 11:10:24 PDT
Created attachment 100331 [details] Patch
Kent Tamura
Comment 2 2011-07-11 19:10:40 PDT
Comment on attachment 100331 [details] Patch Is there no corresponding C++ code change?
Yuta Kitamura
Comment 3 2011-07-11 20:01:28 PDT
(In reply to comment #2) > (From update of attachment 100331 [details]) > Is there no corresponding C++ code change? I can make a patch with WebCore changes, but these tests cannot be enabled yet because pywebsocket do not accept half-baked client implementation (i.e. hybi handshake + hixie76 framing). If this makes sense for you, I'm happy to withdraw this patch and create a patch with C++ code change.
Kent Tamura
Comment 4 2011-07-11 20:19:12 PDT
(In reply to comment #3) > I can make a patch with WebCore changes, but these tests cannot be enabled yet because pywebsocket do not accept half-baked client implementation (i.e. hybi handshake + hixie76 framing). If this makes sense for you, I'm happy to withdraw this patch and create a patch with C++ code change. ok, I understand your intention. The test-only change is acceptable, but C++-only change would not be acceptable to me because test changes are very helpful to understand the C++ change. I like C++ change with the corresponding test change. Other reviewers might have different preferences.
Yuta Kitamura
Comment 5 2011-07-11 20:33:25 PDT
Okay, I'm abondoning this change.
Note You need to log in before you can comment on or make changes to this bug.